diff mbox series

[2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers

Message ID 20191002160744.11307-2-krzk@kernel.org
State New
Headers show
Series [1/4] dt-bindings: samsung: Indent examples with four spaces | expand

Commit Message

Krzysztof Kozlowski Oct. 2, 2019, 4:07 p.m. UTC
Make the examples in S3C RTC bindings more readable and bring them
closer to real DTS by using defines for clocks.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Alexandre Belloni Oct. 7, 2019, 1:17 p.m. UTC | #1
On 02/10/2019 18:07:42+0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 95570d7e19eb..4d91cdc9b998 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -75,11 +75,14 @@ allOf:
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/exynos5420.h>
> +    #include <dt-bindings/clock/samsung,s2mps11.h>
> +
>      rtc@10070000 {
>          compatible = "samsung,s3c6410-rtc";
>          reg = <0x10070000 0x100>;
>          interrupts = <0 44 4>, <0 45 4>;
> -        clocks = <&clock 0>, // CLK_RTC
> -                 <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> +        clocks = <&clock CLK_RTC>,
> +                 <&s2mps11_osc S2MPS11_CLK_AP>;
>          clock-names = "rtc", "rtc_src";
>      };
> -- 
> 2.17.1
>
Rob Herring Oct. 15, 2019, 5:10 p.m. UTC | #2
On Wed,  2 Oct 2019 18:07:42 +0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
index 95570d7e19eb..4d91cdc9b998 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
@@ -75,11 +75,14 @@  allOf:
 
 examples:
   - |
+    #include <dt-bindings/clock/exynos5420.h>
+    #include <dt-bindings/clock/samsung,s2mps11.h>
+
     rtc@10070000 {
         compatible = "samsung,s3c6410-rtc";
         reg = <0x10070000 0x100>;
         interrupts = <0 44 4>, <0 45 4>;
-        clocks = <&clock 0>, // CLK_RTC
-                 <&s2mps11_osc 0>; // S2MPS11_CLK_AP
+        clocks = <&clock CLK_RTC>,
+                 <&s2mps11_osc S2MPS11_CLK_AP>;
         clock-names = "rtc", "rtc_src";
     };