diff mbox series

[v3,8/8] dt-bindings: Add max12xx SPI ADC series as trivial devices

Message ID 20191007132657.4190-9-miquel.raynal@bootlin.com (mailing list archive)
State New, archived
Headers show
Series Introduce max12xx ADC support | expand

Commit Message

Miquel Raynal Oct. 7, 2019, 1:26 p.m. UTC
Update the compatible list with three Maxim ADCs compatibles.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 .../bindings/iio/adc/max1027-adc.txt          | 28 +++++++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml  |  6 ++++
 2 files changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt

Comments

Rob Herring (Arm) Oct. 10, 2019, 8:47 p.m. UTC | #1
On Mon, Oct 07, 2019 at 03:26:57PM +0200, Miquel Raynal wrote:
> Update the compatible list with three Maxim ADCs compatibles.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../bindings/iio/adc/max1027-adc.txt          | 28 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  6 ++++
>  2 files changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt

Devices are supposed to be documented in one place or the other. So 
either make max1027-adc.txt a schema or drop it.

I'm fine either way. Obviously, trivial-devices.yaml is trivial to add 
to, but it does leave some ambiguities. Like is an interrupt required, 
optional or non-existent? What about power supplies? Or what are allowed 
values for spi-max-frequency.

Rob
Miquel Raynal Oct. 10, 2019, 9:31 p.m. UTC | #2
Hi Rob,

Rob Herring <robh@kernel.org> wrote on Thu, 10 Oct 2019 15:47:51 -0500:

> On Mon, Oct 07, 2019 at 03:26:57PM +0200, Miquel Raynal wrote:
> > Update the compatible list with three Maxim ADCs compatibles.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  .../bindings/iio/adc/max1027-adc.txt          | 28 +++++++++++++++++++
> >  .../devicetree/bindings/trivial-devices.yaml  |  6 ++++
> >  2 files changed, 34 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt  
> 
> Devices are supposed to be documented in one place or the other. So 
> either make max1027-adc.txt a schema or drop it.
> 
> I'm fine either way. Obviously, trivial-devices.yaml is trivial to add 
> to, but it does leave some ambiguities. Like is an interrupt required, 
> optional or non-existent? What about power supplies? Or what are allowed 
> values for spi-max-frequency.

Rhaaa... I obviously wanted to drop the *txt file, just forgot to do
it. As the interrupts are optional I found the trivial device
description accurate enough.

Thanks,
Miquèl
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
new file mode 100644
index 000000000000..1b703a01d882
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
@@ -0,0 +1,28 @@ 
+* Maxim 1027/1029/1031/1227/1229/1231 Analog to Digital Converter (ADC)
+
+Required properties:
+  - compatible: Should be one of:
+    * "maxim,max1027"
+    * "maxim,max1029"
+    * "maxim,max1031"
+    * "maxim,max1227"
+    * "maxim,max1229"
+    * "maxim,max1231"
+  - reg: SPI chip select number for the device
+
+Optional properties:
+  - interrupts: IRQ line for the ADC
+  see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
+
+Recommended properties:
+- spi-max-frequency: Definition as per
+                     Documentation/devicetree/bindings/spi/spi-bus.txt
+
+Example:
+adc@0 {
+	compatible = "maxim,max1027";
+	reg = <0>;
+	interrupt-parent = <&gpio5>;
+	interrupts = <15 IRQ_TYPE_EDGE_RISING>;
+	spi-max-frequency = <1000000>;
+};
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index e0095ecb472f..765fd1c170df 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -120,6 +120,12 @@  properties:
           - maxim,max1029
             # 10-bit 16 channels 300ks/s SPI ADC with temperature sensor
           - maxim,max1031
+            # 12-bit 8 channels 300ks/s SPI ADC with temperature sensor
+          - maxim,max1227
+            # 12-bit 12 channels 300ks/s SPI ADC with temperature sensor
+          - maxim,max1229
+            # 12-bit 16 channels 300ks/s SPI ADC with temperature sensor
+          - maxim,max1231
             # Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
           - maxim,max1237
             # PECI-to-I2C translator for PECI-to-SMBus/I2C protocol conversion