| Message ID | 20191013122512.1793656-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: cc10001: use devm_platform_ioremap_resource | expand |
On Sun, 2019-10-13 at 13:25 +0100, jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Reduces local boilerplate. > Found by coccinelle: > > drivers/iio/adc/cc10001_adc.c:344:1-18: WARNING: Use > devm_platform_ioremap_resource for adc_dev -> reg_base > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Naidu Tellapati <naidu.tellapati@imgtec.com> > --- > drivers/iio/adc/cc10001_adc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/cc10001_adc.c > b/drivers/iio/adc/cc10001_adc.c > index f93f1d93b80d..fe9257624f16 100644 > --- a/drivers/iio/adc/cc10001_adc.c > +++ b/drivers/iio/adc/cc10001_adc.c > @@ -310,7 +310,6 @@ static int cc10001_adc_probe(struct platform_device > *pdev) > struct device_node *node = pdev->dev.of_node; > struct cc10001_adc_device *adc_dev; > unsigned long adc_clk_rate; > - struct resource *res; > struct iio_dev *indio_dev; > unsigned long channel_map; > int ret; > @@ -340,8 +339,7 @@ static int cc10001_adc_probe(struct platform_device > *pdev) > indio_dev->info = &cc10001_adc_info; > indio_dev->modes = INDIO_DIRECT_MODE; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res); > + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(adc_dev->reg_base)) { > ret = PTR_ERR(adc_dev->reg_base); > goto err_disable_reg;
On Mon, 4 Nov 2019 15:15:50 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Sun, 2019-10-13 at 13:25 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Reduces local boilerplate. > > Found by coccinelle: > > > > drivers/iio/adc/cc10001_adc.c:344:1-18: WARNING: Use > > devm_platform_ioremap_resource for adc_dev -> reg_base > > > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied. Thanks, Jonathan > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Naidu Tellapati <naidu.tellapati@imgtec.com> > > --- > > drivers/iio/adc/cc10001_adc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/cc10001_adc.c > > b/drivers/iio/adc/cc10001_adc.c > > index f93f1d93b80d..fe9257624f16 100644 > > --- a/drivers/iio/adc/cc10001_adc.c > > +++ b/drivers/iio/adc/cc10001_adc.c > > @@ -310,7 +310,6 @@ static int cc10001_adc_probe(struct platform_device > > *pdev) > > struct device_node *node = pdev->dev.of_node; > > struct cc10001_adc_device *adc_dev; > > unsigned long adc_clk_rate; > > - struct resource *res; > > struct iio_dev *indio_dev; > > unsigned long channel_map; > > int ret; > > @@ -340,8 +339,7 @@ static int cc10001_adc_probe(struct platform_device > > *pdev) > > indio_dev->info = &cc10001_adc_info; > > indio_dev->modes = INDIO_DIRECT_MODE; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res); > > + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(adc_dev->reg_base)) { > > ret = PTR_ERR(adc_dev->reg_base); > > goto err_disable_reg;
diff --git a/drivers/iio/adc/cc10001_adc.c b/drivers/iio/adc/cc10001_adc.c index f93f1d93b80d..fe9257624f16 100644 --- a/drivers/iio/adc/cc10001_adc.c +++ b/drivers/iio/adc/cc10001_adc.c @@ -310,7 +310,6 @@ static int cc10001_adc_probe(struct platform_device *pdev) struct device_node *node = pdev->dev.of_node; struct cc10001_adc_device *adc_dev; unsigned long adc_clk_rate; - struct resource *res; struct iio_dev *indio_dev; unsigned long channel_map; int ret; @@ -340,8 +339,7 @@ static int cc10001_adc_probe(struct platform_device *pdev) indio_dev->info = &cc10001_adc_info; indio_dev->modes = INDIO_DIRECT_MODE; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res); + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(adc_dev->reg_base)) { ret = PTR_ERR(adc_dev->reg_base); goto err_disable_reg;