| Message ID | 20191013171414.2154379-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: dac: lpc18xx: Use devm_platform_ioremap_resource | expand |
On Sun, 2019-10-13 at 18:14 +0100, jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Reduce boilerplate. > Suggested by coccinelle > CHECK drivers/iio/dac/lpc18xx_dac.c > drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use > devm_platform_ioremap_resource for dac -> base > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > CC: Joachim Eastwood <manabian@gmail.com> > --- > drivers/iio/dac/lpc18xx_dac.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/dac/lpc18xx_dac.c > b/drivers/iio/dac/lpc18xx_dac.c > index 883e84e96609..0ab357bd3633 100644 > --- a/drivers/iio/dac/lpc18xx_dac.c > +++ b/drivers/iio/dac/lpc18xx_dac.c > @@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device > *pdev) > { > struct iio_dev *indio_dev; > struct lpc18xx_dac *dac; > - struct resource *res; > int ret; > > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac)); > @@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device > *pdev) > dac = iio_priv(indio_dev); > mutex_init(&dac->lock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - dac->base = devm_ioremap_resource(&pdev->dev, res); > + dac->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(dac->base)) > return PTR_ERR(dac->base); >
On Mon, 4 Nov 2019 15:16:44 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Sun, 2019-10-13 at 18:14 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Reduce boilerplate. > > Suggested by coccinelle > > CHECK drivers/iio/dac/lpc18xx_dac.c > > drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use > > devm_platform_ioremap_resource for dac -> base > > > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Applied, Thanks, J > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > CC: Joachim Eastwood <manabian@gmail.com> > > --- > > drivers/iio/dac/lpc18xx_dac.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/dac/lpc18xx_dac.c > > b/drivers/iio/dac/lpc18xx_dac.c > > index 883e84e96609..0ab357bd3633 100644 > > --- a/drivers/iio/dac/lpc18xx_dac.c > > +++ b/drivers/iio/dac/lpc18xx_dac.c > > @@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device > > *pdev) > > { > > struct iio_dev *indio_dev; > > struct lpc18xx_dac *dac; > > - struct resource *res; > > int ret; > > > > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac)); > > @@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device > > *pdev) > > dac = iio_priv(indio_dev); > > mutex_init(&dac->lock); > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - dac->base = devm_ioremap_resource(&pdev->dev, res); > > + dac->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(dac->base)) > > return PTR_ERR(dac->base); > >
diff --git a/drivers/iio/dac/lpc18xx_dac.c b/drivers/iio/dac/lpc18xx_dac.c index 883e84e96609..0ab357bd3633 100644 --- a/drivers/iio/dac/lpc18xx_dac.c +++ b/drivers/iio/dac/lpc18xx_dac.c @@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) { struct iio_dev *indio_dev; struct lpc18xx_dac *dac; - struct resource *res; int ret; indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac)); @@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device *pdev) dac = iio_priv(indio_dev); mutex_init(&dac->lock); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - dac->base = devm_ioremap_resource(&pdev->dev, res); + dac->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dac->base)) return PTR_ERR(dac->base);