diff mbox series

[1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support

Message ID 20200130131549.1170-1-u.kleine-koenig@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series [1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support | expand

Commit Message

Uwe Kleine-König Jan. 30, 2020, 1:15 p.m. UTC
The ltc2636 family of devices is register compatible with the ltc2636
chips, it just features 8 instead of 2 channels.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 Documentation/devicetree/bindings/iio/dac/ltc2632.txt | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Jonathan Cameron Feb. 2, 2020, 9:52 a.m. UTC | #1
On Thu, 30 Jan 2020 14:15:47 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> The ltc2636 family of devices is register compatible with the ltc2636
> chips, it just features 8 instead of 2 channels.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/iio/dac/ltc2632.txt | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> index e0d5fea33031..9d114957a28b 100644
> --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> +++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> @@ -1,4 +1,4 @@
> -Linear Technology LTC2632 DAC device driver
> +Linear Technology LTC2632/2636 DAC device driver

Whilst we are here, can we clear out the reference to 'driver'.
It's a binding so describes the hardware, not the driver talking
to it.

Linear Technology LTC... DAC

If that's all that comes up, I can tidy this up when applying.

Jonathan

>  
>  Required properties:
>   - compatible: Has to contain one of the following:
> @@ -8,6 +8,12 @@ Required properties:
>  	lltc,ltc2632-h12
>  	lltc,ltc2632-h10
>  	lltc,ltc2632-h8
> +	lltc,ltc2636-l12
> +	lltc,ltc2636-l10
> +	lltc,ltc2636-l8
> +	lltc,ltc2636-h12
> +	lltc,ltc2636-h10
> +	lltc,ltc2636-h8
>  
>  Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
>  apply. In particular, "reg" and "spi-max-frequency" properties must be given.
Jonathan Cameron Feb. 6, 2020, 10:42 a.m. UTC | #2
On Sun, 2 Feb 2020 09:52:07 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Thu, 30 Jan 2020 14:15:47 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> 
> > The ltc2636 family of devices is register compatible with the ltc2636
> > chips, it just features 8 instead of 2 channels.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/iio/dac/ltc2632.txt | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> > index e0d5fea33031..9d114957a28b 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> > +++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
> > @@ -1,4 +1,4 @@
> > -Linear Technology LTC2632 DAC device driver
> > +Linear Technology LTC2632/2636 DAC device driver  
> 
> Whilst we are here, can we clear out the reference to 'driver'.
> It's a binding so describes the hardware, not the driver talking
> to it.
> 
> Linear Technology LTC... DAC
> 
> If that's all that comes up, I can tidy this up when applying.

Applied.

Thanks,
> 
> Jonathan
> 
> >  
> >  Required properties:
> >   - compatible: Has to contain one of the following:
> > @@ -8,6 +8,12 @@ Required properties:
> >  	lltc,ltc2632-h12
> >  	lltc,ltc2632-h10
> >  	lltc,ltc2632-h8
> > +	lltc,ltc2636-l12
> > +	lltc,ltc2636-l10
> > +	lltc,ltc2636-l8
> > +	lltc,ltc2636-h12
> > +	lltc,ltc2636-h10
> > +	lltc,ltc2636-h8
> >  
> >  Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
> >  apply. In particular, "reg" and "spi-max-frequency" properties must be given.  
>
Rob Herring (Arm) Feb. 6, 2020, 6:11 p.m. UTC | #3
On Thu, 30 Jan 2020 14:15:47 +0100, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= wrote:
> The ltc2636 family of devices is register compatible with the ltc2636
> chips, it just features 8 instead of 2 channels.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/iio/dac/ltc2632.txt | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
index e0d5fea33031..9d114957a28b 100644
--- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
+++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
@@ -1,4 +1,4 @@ 
-Linear Technology LTC2632 DAC device driver
+Linear Technology LTC2632/2636 DAC device driver
 
 Required properties:
  - compatible: Has to contain one of the following:
@@ -8,6 +8,12 @@  Required properties:
 	lltc,ltc2632-h12
 	lltc,ltc2632-h10
 	lltc,ltc2632-h8
+	lltc,ltc2636-l12
+	lltc,ltc2636-l10
+	lltc,ltc2636-l8
+	lltc,ltc2636-h12
+	lltc,ltc2636-h10
+	lltc,ltc2636-h8
 
 Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
 apply. In particular, "reg" and "spi-max-frequency" properties must be given.