| Message ID | 20200203203126.7003-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] dt-bindings: iio: ltc2632: expand for ltc2636 support | expand |
On Mon, 3 Feb 2020 21:31:26 +0100 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > These two defines are unused since the driver was introduced in commit > 02b829f9e11f ("iio: dac: Add support for ltc2632 DACs"). > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> A bit of fuzz and the mysterious bit of this being patch 4 of 3 aside all good. Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > --- > drivers/iio/dac/ltc2632.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c > index 1e7ffa0f6071..7adc91056aa1 100644 > --- a/drivers/iio/dac/ltc2632.c > +++ b/drivers/iio/dac/ltc2632.c > @@ -12,9 +12,6 @@ > #include <linux/iio/iio.h> > #include <linux/regulator/consumer.h> > > -#define LTC2632_ADDR_DAC0 0x0 > -#define LTC2632_ADDR_DAC1 0x1 > - > #define LTC2632_CMD_WRITE_INPUT_N 0x0 > #define LTC2632_CMD_UPDATE_DAC_N 0x1 > #define LTC2632_CMD_WRITE_INPUT_N_UPDATE_ALL 0x2
On Thu, Feb 06, 2020 at 10:29:15AM +0000, Jonathan Cameron wrote: > On Mon, 3 Feb 2020 21:31:26 +0100 > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > These two defines are unused since the driver was introduced in commit > > 02b829f9e11f ("iio: dac: Add support for ltc2632 DACs"). > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > A bit of fuzz and the mysterious bit of this being patch 4 of 3 aside all good. > > Applied to the togreg branch of iio.git and pushed out as testing. If you applied patches 2 and 3 of the series before, the fuzz should disappear. I assume the threading didn't work as intended for you and you don't have the original patch series grouped with my patch 4/3? Best regards Uwe
On Thu, 6 Feb 2020 11:34:43 +0100 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Thu, Feb 06, 2020 at 10:29:15AM +0000, Jonathan Cameron wrote: > > On Mon, 3 Feb 2020 21:31:26 +0100 > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > > > These two defines are unused since the driver was introduced in commit > > > 02b829f9e11f ("iio: dac: Add support for ltc2632 DACs"). > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > A bit of fuzz and the mysterious bit of this being patch 4 of 3 aside all good. > > > > Applied to the togreg branch of iio.git and pushed out as testing. > > If you applied patches 2 and 3 of the series before, the fuzz should > disappear. I assume the threading didn't work as intended for you and > you don't have the original patch series grouped with my patch 4/3? Yup. Just realised that after sending :) I'll apply them in the right order. Jonathan > > Best regards > Uwe >
On Thu, Feb 06, 2020 at 10:44:18AM +0000, Jonathan Cameron wrote: > On Thu, 6 Feb 2020 11:34:43 +0100 > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > On Thu, Feb 06, 2020 at 10:29:15AM +0000, Jonathan Cameron wrote: > > > On Mon, 3 Feb 2020 21:31:26 +0100 > > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > > > > > These two defines are unused since the driver was introduced in commit > > > > 02b829f9e11f ("iio: dac: Add support for ltc2632 DACs"). > > > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > A bit of fuzz and the mysterious bit of this being patch 4 of 3 aside all good. > > > > > > Applied to the togreg branch of iio.git and pushed out as testing. > > > > If you applied patches 2 and 3 of the series before, the fuzz should > > disappear. I assume the threading didn't work as intended for you and > > you don't have the original patch series grouped with my patch 4/3? > Yup. Just realised that after sending :) > > I'll apply them in the right order. Last time I already wondered why patches you applied don't appear in next. This had something to do with the workflow how patches go from you over Greg to Linus. Given that next is different and in my experience it is possible to get a tree into next even as a "second-level" maintainer, I wonder if adding your tree would be beneficial. You applied the patch more than two weeks ago and there is still no exposure to next. :-| Best regards Uwe
On Tue, 25 Feb 2020 10:32:59 +0100 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Thu, Feb 06, 2020 at 10:44:18AM +0000, Jonathan Cameron wrote: > > On Thu, 6 Feb 2020 11:34:43 +0100 > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > > > On Thu, Feb 06, 2020 at 10:29:15AM +0000, Jonathan Cameron wrote: > > > > On Mon, 3 Feb 2020 21:31:26 +0100 > > > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > > > > > > > > These two defines are unused since the driver was introduced in commit > > > > > 02b829f9e11f ("iio: dac: Add support for ltc2632 DACs"). > > > > > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > A bit of fuzz and the mysterious bit of this being patch 4 of 3 aside all good. > > > > > > > > Applied to the togreg branch of iio.git and pushed out as testing. > > > > > > If you applied patches 2 and 3 of the series before, the fuzz should > > > disappear. I assume the threading didn't work as intended for you and > > > you don't have the original patch series grouped with my patch 4/3? > > Yup. Just realised that after sending :) > > > > I'll apply them in the right order. > > Last time I already wondered why patches you applied don't appear in > next. This had something to do with the workflow how patches go from you > over Greg to Linus. > > Given that next is different and in my experience it is possible to get > a tree into next even as a "second-level" maintainer, I wonder if adding > your tree would be beneficial. You applied the patch more than two weeks > ago and there is still no exposure to next. :-| Ideally things would normally move quicker. I've been fighting off a nasty and very persistent cold so running rather behind. Agreed in theory it would make sense to take IIO directly into next, but to do that the issue is that my availability can be rather intermittent so I try to time pull requests to Greg for times when I can deal with any fall out the over the next few days. It's not uncommon for there to be problems and I hate to annoy people by not being able to sort them in a timely fashion. Anyhow, I'll look at it again sometime soon. Jonathan > > Best regards > Uwe >
diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c index 1e7ffa0f6071..7adc91056aa1 100644 --- a/drivers/iio/dac/ltc2632.c +++ b/drivers/iio/dac/ltc2632.c @@ -12,9 +12,6 @@ #include <linux/iio/iio.h> #include <linux/regulator/consumer.h> -#define LTC2632_ADDR_DAC0 0x0 -#define LTC2632_ADDR_DAC1 0x1 - #define LTC2632_CMD_WRITE_INPUT_N 0x0 #define LTC2632_CMD_UPDATE_DAC_N 0x1 #define LTC2632_CMD_WRITE_INPUT_N_UPDATE_ALL 0x2
These two defines are unused since the driver was introduced in commit 02b829f9e11f ("iio: dac: Add support for ltc2632 DACs"). Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/iio/dac/ltc2632.c | 3 --- 1 file changed, 3 deletions(-)