| Message ID | 20200227135227.12433-2-alexandru.ardelean@analog.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] iio: core: drop devm_iio_device_unregister() API call | expand |
On Thu, 27 Feb 2020 15:52:21 +0200 Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > It's unused so far, so it can't be removed. Also makes sense to remove it > to discourage weird uses of this call during review. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied, Thanks, J > --- > Documentation/driver-api/driver-model/devres.rst | 1 - > drivers/iio/buffer/industrialio-triggered-buffer.c | 11 ----------- > include/linux/iio/triggered_buffer.h | 2 -- > 3 files changed, 14 deletions(-) > > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst > index 0580c64ebdfd..1431d5e44abc 100644 > --- a/Documentation/driver-api/driver-model/devres.rst > +++ b/Documentation/driver-api/driver-model/devres.rst > @@ -289,7 +289,6 @@ IIO > devm_iio_kfifo_allocate() > devm_iio_kfifo_free() > devm_iio_triggered_buffer_setup() > - devm_iio_triggered_buffer_cleanup() > devm_iio_trigger_alloc() > devm_iio_trigger_free() > devm_iio_trigger_register() > diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c > index cb322b2f09cd..e8046c1ecd6b 100644 > --- a/drivers/iio/buffer/industrialio-triggered-buffer.c > +++ b/drivers/iio/buffer/industrialio-triggered-buffer.c > @@ -126,17 +126,6 @@ int devm_iio_triggered_buffer_setup(struct device *dev, > } > EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_setup); > > -void devm_iio_triggered_buffer_cleanup(struct device *dev, > - struct iio_dev *indio_dev) > -{ > - int rc; > - > - rc = devres_release(dev, devm_iio_triggered_buffer_clean, > - devm_iio_device_match, indio_dev); > - WARN_ON(rc); > -} > -EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_cleanup); > - > MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>"); > MODULE_DESCRIPTION("IIO helper functions for setting up triggered buffers"); > MODULE_LICENSE("GPL"); > diff --git a/include/linux/iio/triggered_buffer.h b/include/linux/iio/triggered_buffer.h > index 238ad30ce166..e99c91799359 100644 > --- a/include/linux/iio/triggered_buffer.h > +++ b/include/linux/iio/triggered_buffer.h > @@ -18,7 +18,5 @@ int devm_iio_triggered_buffer_setup(struct device *dev, > irqreturn_t (*h)(int irq, void *p), > irqreturn_t (*thread)(int irq, void *p), > const struct iio_buffer_setup_ops *ops); > -void devm_iio_triggered_buffer_cleanup(struct device *dev, > - struct iio_dev *indio_dev); > > #endif
diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst index 0580c64ebdfd..1431d5e44abc 100644 --- a/Documentation/driver-api/driver-model/devres.rst +++ b/Documentation/driver-api/driver-model/devres.rst @@ -289,7 +289,6 @@ IIO devm_iio_kfifo_allocate() devm_iio_kfifo_free() devm_iio_triggered_buffer_setup() - devm_iio_triggered_buffer_cleanup() devm_iio_trigger_alloc() devm_iio_trigger_free() devm_iio_trigger_register() diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c index cb322b2f09cd..e8046c1ecd6b 100644 --- a/drivers/iio/buffer/industrialio-triggered-buffer.c +++ b/drivers/iio/buffer/industrialio-triggered-buffer.c @@ -126,17 +126,6 @@ int devm_iio_triggered_buffer_setup(struct device *dev, } EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_setup); -void devm_iio_triggered_buffer_cleanup(struct device *dev, - struct iio_dev *indio_dev) -{ - int rc; - - rc = devres_release(dev, devm_iio_triggered_buffer_clean, - devm_iio_device_match, indio_dev); - WARN_ON(rc); -} -EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_cleanup); - MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>"); MODULE_DESCRIPTION("IIO helper functions for setting up triggered buffers"); MODULE_LICENSE("GPL"); diff --git a/include/linux/iio/triggered_buffer.h b/include/linux/iio/triggered_buffer.h index 238ad30ce166..e99c91799359 100644 --- a/include/linux/iio/triggered_buffer.h +++ b/include/linux/iio/triggered_buffer.h @@ -18,7 +18,5 @@ int devm_iio_triggered_buffer_setup(struct device *dev, irqreturn_t (*h)(int irq, void *p), irqreturn_t (*thread)(int irq, void *p), const struct iio_buffer_setup_ops *ops); -void devm_iio_triggered_buffer_cleanup(struct device *dev, - struct iio_dev *indio_dev); #endif
It's unused so far, so it can't be removed. Also makes sense to remove it to discourage weird uses of this call during review. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> --- Documentation/driver-api/driver-model/devres.rst | 1 - drivers/iio/buffer/industrialio-triggered-buffer.c | 11 ----------- include/linux/iio/triggered_buffer.h | 2 -- 3 files changed, 14 deletions(-)