| Message ID | 20200310141654.7188-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] iio:ad7797: Use correct attribute_group | expand |
On Tue, 10 Mar 2020 22:16:54 +0800 YueHaibing <yuehaibing@huawei.com> wrote: > It should use ad7797_attribute_group in ad7797_info, > according to commit ("iio:ad7793: Add support for the ad7796 and ad7797"). > > Scale is fixed for the ad7796 and not programmable, hence > should not have the scale_available attribute. > > Fixes: fd1a8b912841 ("iio:ad7793: Add support for the ad7796 and ad7797") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Reviewed-by: Lars-Peter Clausen <lars@metafoo.de> Thanks, I've queued this up. Won't push out just yet as I'm waiting for Greg to pick up a pull request after which I'd like to fast forward the fixes branch. Thanks, Jonathan > --- > v2: renew log as Lars-Peter's comment > > drivers/iio/adc/ad7793.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c > index b747db9..e5691e3 100644 > --- a/drivers/iio/adc/ad7793.c > +++ b/drivers/iio/adc/ad7793.c > @@ -542,7 +542,7 @@ static const struct iio_info ad7797_info = { > .read_raw = &ad7793_read_raw, > .write_raw = &ad7793_write_raw, > .write_raw_get_fmt = &ad7793_write_raw_get_fmt, > - .attrs = &ad7793_attribute_group, > + .attrs = &ad7797_attribute_group, > .validate_trigger = ad_sd_validate_trigger, > }; >
diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c index b747db9..e5691e3 100644 --- a/drivers/iio/adc/ad7793.c +++ b/drivers/iio/adc/ad7793.c @@ -542,7 +542,7 @@ static const struct iio_info ad7797_info = { .read_raw = &ad7793_read_raw, .write_raw = &ad7793_write_raw, .write_raw_get_fmt = &ad7793_write_raw_get_fmt, - .attrs = &ad7793_attribute_group, + .attrs = &ad7797_attribute_group, .validate_trigger = ad_sd_validate_trigger, };
It should use ad7797_attribute_group in ad7797_info, according to commit ("iio:ad7793: Add support for the ad7796 and ad7797"). Scale is fixed for the ad7796 and not programmable, hence should not have the scale_available attribute. Fixes: fd1a8b912841 ("iio:ad7793: Add support for the ad7796 and ad7797") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de> --- v2: renew log as Lars-Peter's comment drivers/iio/adc/ad7793.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)