diff mbox series

[2/3] dt-bindings: iio: dac: ad5770r: Remove unneeded unit names

Message ID 20200327131825.23650-2-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/3] dt-bindings: iio: dac: ad5770r: Add vendor to compatible string | expand

Commit Message

Fabio Estevam March 27, 2020, 1:18 p.m. UTC
The following warnings are seen with 'make dt_binding_check':

Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:29.35-32.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@0: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:34.35-37.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@1: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:39.35-42.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@2: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:44.35-47.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@3: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:49.35-52.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@4: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:54.35-57.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@5: node has a unit name, but no reg or ranges property

Fix them by removing the unneeded unit addresses.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 .../devicetree/bindings/iio/dac/adi,ad5770r.yaml     | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Rob Herring March 27, 2020, 9:05 p.m. UTC | #1
On Fri, Mar 27, 2020 at 7:18 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> The following warnings are seen with 'make dt_binding_check':
>
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:29.35-32.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@0: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:34.35-37.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@1: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:39.35-42.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@2: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:44.35-47.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@3: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:49.35-52.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@4: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:54.35-57.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@5: node has a unit name, but no reg or ranges property
>
> Fix them by removing the unneeded unit addresses.

Actually, we want to use 'reg' instead of 'num'. Alexandru is
attempting to fix[1].

But looks like you found another issue with patch 1.

Rob

[1] https://lore.kernel.org/linux-iio/CAL_JsqKFdcACQtXd5h=4Pxbij+=uoHr2rLTFZMq4fVX8ph398g@mail.gmail.com/
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
index f937040477ec..fa86ef52b121 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
@@ -151,32 +151,32 @@  examples:
                         adi,external-resistor;
                         reset-gpios = <&gpio 22 0>;
 
-                        channel@0 {
+                        channel0 {
                                 num = <0>;
                                 adi,range-microamp = <(-60000) 300000>;
                         };
 
-                        channel@1 {
+                        channel1 {
                                 num = <1>;
                                 adi,range-microamp = <0 140000>;
                         };
 
-                        channel@2 {
+                        channel2 {
                                 num = <2>;
                                 adi,range-microamp = <0 55000>;
                         };
 
-                        channel@3 {
+                        channel3 {
                                 num = <3>;
                                 adi,range-microamp = <0 45000>;
                         };
 
-                        channel@4 {
+                        channel4 {
                                 num = <4>;
                                 adi,range-microamp = <0 45000>;
                         };
 
-                        channel@5 {
+                        channel5 {
                                 num = <5>;
                                 adi,range-microamp = <0 45000>;
                         };