diff mbox series

iio:accel:bma180: Fix the shared by parameter for an enum

Message ID 20200707203044.369103-1-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series iio:accel:bma180: Fix the shared by parameter for an enum | expand

Commit Message

Jonathan Cameron July 7, 2020, 8:30 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This takes an enum, not a boolean. Discovered via warning when doing
a W=1 build.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes: fdadbce0da4 ("iio: add Bosch BMA180 acceleration sensor driver")
---
 drivers/iio/accel/bma180.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron July 8, 2020, 3:41 p.m. UTC | #1 
On Tue, 7 Jul 2020 21:30:44 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Title on this one is gibberish.  Let us pretend that says

Fix: Use enum value IIO_SHARED_BY_ALL instead of a boolean.

> 
> This takes an enum, not a boolean. Discovered via warning when doing
> a W=1 build.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: fdadbce0da4 ("iio: add Bosch BMA180 acceleration sensor driver")
> ---
>  drivers/iio/accel/bma180.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index 5b7a467c7b27..3246a5ef7360 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
>  };
>  
>  static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
> -	IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
> +	IIO_ENUM("power_mode", IIO_SHARED_BY_ALL, &bma180_power_mode_enum),
>  	IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
>  	IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
>  	{ }
diff mbox series

Patch

diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 5b7a467c7b27..3246a5ef7360 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -673,7 +673,7 @@  static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
 };
 
 static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
-	IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
+	IIO_ENUM("power_mode", IIO_SHARED_BY_ALL, &bma180_power_mode_enum),
 	IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
 	IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
 	{ }