| Message ID | 20200723230344.1422750-3-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Some sx9310 iio driver updates | expand |
Hi, On Thu, Jul 23, 2020 at 4:03 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Printks in the kernel have newlines at the end. Add them to the few > printks in this driver. > > Cc: Gwendal Grignou <gwendal@chromium.org> > Cc: Daniel Campello <campello@chromium.org> > Cc: Hartmut Knaack <knaack.h@gmx.de> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > Cc: Douglas Anderson <dianders@chromium.org> > Fixes: 72ad02b15d63 ("iio: Add SEMTECH SX9310/9311 sensor driver") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/iio/proximity/sx9310.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hi, On Thu, Jul 23, 2020 at 5:03 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Printks in the kernel have newlines at the end. Add them to the few > printks in this driver. > > Cc: Gwendal Grignou <gwendal@chromium.org> > Cc: Daniel Campello <campello@chromium.org> > Cc: Hartmut Knaack <knaack.h@gmx.de> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> > Cc: Douglas Anderson <dianders@chromium.org> > Fixes: 72ad02b15d63 ("iio: Add SEMTECH SX9310/9311 sensor driver") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/iio/proximity/sx9310.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Daniel Campello <campello@chromium.org>
diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c index d161f3061e35..84c3c9ae80dc 100644 --- a/drivers/iio/proximity/sx9310.c +++ b/drivers/iio/proximity/sx9310.c @@ -824,7 +824,7 @@ static int sx9310_init_compensation(struct iio_dev *indio_dev) if (i < 0) { dev_err(&data->client->dev, - "initial compensation timed out: 0x%02x", val); + "initial compensation timed out: 0x%02x\n", val); ret = -ETIMEDOUT; } @@ -871,14 +871,14 @@ static int sx9310_set_indio_dev_name(struct device *dev, /* id will be NULL when enumerated via ACPI */ if (id) { if (id->driver_data != whoami) - dev_err(dev, "WHOAMI does not match i2c_device_id: %s", + dev_err(dev, "WHOAMI does not match i2c_device_id: %s\n", id->name); } else if (ACPI_HANDLE(dev)) { acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev); if (!acpi_id) return -ENODEV; if (acpi_id->driver_data != whoami) - dev_err(dev, "WHOAMI does not match acpi_device_id: %s", + dev_err(dev, "WHOAMI does not match acpi_device_id: %s\n", acpi_id->id); } else return -ENODEV; @@ -891,7 +891,7 @@ static int sx9310_set_indio_dev_name(struct device *dev, indio_dev->name = "sx9311"; break; default: - dev_err(dev, "unexpected WHOAMI response: %u", whoami); + dev_err(dev, "unexpected WHOAMI response: %u\n", whoami); return -ENODEV; } @@ -920,7 +920,7 @@ static int sx9310_probe(struct i2c_client *client, ret = regmap_read(data->regmap, SX9310_REG_WHOAMI, &data->whoami); if (ret < 0) { - dev_err(&client->dev, "error in reading WHOAMI register: %d", + dev_err(&client->dev, "error in reading WHOAMI register: %d\n", ret); return ret; }
Printks in the kernel have newlines at the end. Add them to the few printks in this driver. Cc: Gwendal Grignou <gwendal@chromium.org> Cc: Daniel Campello <campello@chromium.org> Cc: Hartmut Knaack <knaack.h@gmx.de> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: Douglas Anderson <dianders@chromium.org> Fixes: 72ad02b15d63 ("iio: Add SEMTECH SX9310/9311 sensor driver") Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/iio/proximity/sx9310.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)