| Message ID | 20200728204825.3312921-1-gwendal@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] iio: cros_ec: Set Gyroscope default frequency to 25Hz | expand |
Hi Gwendal, Thank you for your patch. On 28/7/20 22:48, Gwendal Grignou wrote: > BMI160 Minimium gyroscope frequency in normal mode is 25Hz. > When older EC firmware do not report their sensors frequencies, > use 25Hz as the minimum for gyroscope to be sure it works on BMI160. > > Fixes: ae7b02ad2f32d ("iio: common: cros_ec_sensors: Expose cros_ec_sensors > frequency range via iio sysfs") > I think your email broke this line, it should be a single line. Other than that ... > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > Change since v1: Fix spelling. > > drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > index 156848d27c473..213837c2ecee2 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > @@ -85,10 +85,13 @@ static void get_default_min_max_freq(enum motionsensor_type type, > > switch (type) { > case MOTIONSENSE_TYPE_ACCEL: > - case MOTIONSENSE_TYPE_GYRO: > *min_freq = 12500; > *max_freq = 100000; > break; > + case MOTIONSENSE_TYPE_GYRO: > + *min_freq = 25000; > + *max_freq = 100000; > + break; > case MOTIONSENSE_TYPE_MAG: > *min_freq = 5000; > *max_freq = 25000; >
On Fri, 31 Jul 2020 13:17:53 +0200 Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > Hi Gwendal, > > Thank you for your patch. > > On 28/7/20 22:48, Gwendal Grignou wrote: > > BMI160 Minimium gyroscope frequency in normal mode is 25Hz. > > When older EC firmware do not report their sensors frequencies, > > use 25Hz as the minimum for gyroscope to be sure it works on BMI160. > > > > Fixes: ae7b02ad2f32d ("iio: common: cros_ec_sensors: Expose cros_ec_sensors > > frequency range via iio sysfs") > > > > I think your email broke this line, it should be a single line. Other than that ... > > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan > > > --- > > Change since v1: Fix spelling. > > > > drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > > index 156848d27c473..213837c2ecee2 100644 > > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > > @@ -85,10 +85,13 @@ static void get_default_min_max_freq(enum motionsensor_type type, > > > > switch (type) { > > case MOTIONSENSE_TYPE_ACCEL: > > - case MOTIONSENSE_TYPE_GYRO: > > *min_freq = 12500; > > *max_freq = 100000; > > break; > > + case MOTIONSENSE_TYPE_GYRO: > > + *min_freq = 25000; > > + *max_freq = 100000; > > + break; > > case MOTIONSENSE_TYPE_MAG: > > *min_freq = 5000; > > *max_freq = 25000; > >
diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c index 156848d27c473..213837c2ecee2 100644 --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c @@ -85,10 +85,13 @@ static void get_default_min_max_freq(enum motionsensor_type type, switch (type) { case MOTIONSENSE_TYPE_ACCEL: - case MOTIONSENSE_TYPE_GYRO: *min_freq = 12500; *max_freq = 100000; break; + case MOTIONSENSE_TYPE_GYRO: + *min_freq = 25000; + *max_freq = 100000; + break; case MOTIONSENSE_TYPE_MAG: *min_freq = 5000; *max_freq = 25000;
BMI160 Minimium gyroscope frequency in normal mode is 25Hz. When older EC firmware do not report their sensors frequencies, use 25Hz as the minimum for gyroscope to be sure it works on BMI160. Fixes: ae7b02ad2f32d ("iio: common: cros_ec_sensors: Expose cros_ec_sensors frequency range via iio sysfs") Signed-off-by: Gwendal Grignou <gwendal@chromium.org> --- Change since v1: Fix spelling. drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)