diff mbox series

iio: health: max30102: update author's email

Message ID 20200814134941.10576-1-matt.ranostay@konsulko.com
State New
Headers show
Series iio: health: max30102: update author's email | expand

Commit Message

Matt Ranostay Aug. 14, 2020, 1:49 p.m. UTC
Update email to author's current employer

Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
 drivers/iio/health/max30102.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron Aug. 16, 2020, 8:33 a.m. UTC | #1
On Fri, 14 Aug 2020 06:49:41 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:

> Update email to author's current employer
> 
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied.  Thanks,

Jonathan

> ---
>  drivers/iio/health/max30102.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c
> index 9b47d9472a4f..bb504e993f19 100644
> --- a/drivers/iio/health/max30102.c
> +++ b/drivers/iio/health/max30102.c
> @@ -2,7 +2,7 @@
>  /*
>   * max30102.c - Support for MAX30102 heart rate and pulse oximeter sensor
>   *
> - * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
> + * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>
>   *
>   * Support for MAX30105 optical particle sensor
>   * Copyright (C) 2017 Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> @@ -632,6 +632,6 @@ static struct i2c_driver max30102_driver = {
>  };
>  module_i2c_driver(max30102_driver);
>  
> -MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
> +MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
>  MODULE_DESCRIPTION("MAX30102 heart rate/pulse oximeter and MAX30105 particle sensor driver");
>  MODULE_LICENSE("GPL");
Andy Shevchenko Aug. 16, 2020, 9:51 a.m. UTC | #2
On Sun, Aug 16, 2020 at 1:06 AM Matt Ranostay
<matt.ranostay@konsulko.com> wrote:
>
> Update email to author's current employer

> - * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
> + * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>

> -MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
> +MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");

This is actually an interesting question, had you been working already
for your current employer?
If no, I don't think this is a proper change in the code (of course it
might require your new contract, then it's probably fine, I dunno). It
would be a good change for MAINTAINERS, though.
If yes, the commit message doesn't clarify this.

In any case, just my 2 cents for the future changes like this, since
the patch already applied.
Matt Ranostay Aug. 16, 2020, 10:19 p.m. UTC | #3
On Sun, Aug 16, 2020 at 2:52 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Aug 16, 2020 at 1:06 AM Matt Ranostay
> <matt.ranostay@konsulko.com> wrote:
> >
> > Update email to author's current employer
>
> > - * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
> > + * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>
>
> > -MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
> > +MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
>
> This is actually an interesting question, had you been working already
> for your current employer?

Yes I was, but this was for my independent contracting company (that
has been dissolved, and the email clearly won't work anymore)
for a presentation on iio.

Pretty sure Konsulko doesn't have any issue with copyright assignment
to them :).
Also retroactive assignments are quite legal (under US law at least,
also IANAL) as long you of course own the copyright.

Good questions though!

- Matt

> If no, I don't think this is a proper change in the code (of course it
> might require your new contract, then it's probably fine, I dunno). It
> would be a good change for MAINTAINERS, though.
> If yes, the commit message doesn't clarify this.
>
> In any case, just my 2 cents for the future changes like this, since
> the patch already applied.
>
> --
> With Best Regards,
> Andy Shevchenko
diff mbox series

Patch

diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c
index 9b47d9472a4f..bb504e993f19 100644
--- a/drivers/iio/health/max30102.c
+++ b/drivers/iio/health/max30102.c
@@ -2,7 +2,7 @@ 
 /*
  * max30102.c - Support for MAX30102 heart rate and pulse oximeter sensor
  *
- * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
+ * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>
  *
  * Support for MAX30105 optical particle sensor
  * Copyright (C) 2017 Peter Meerwald-Stadler <pmeerw@pmeerw.net>
@@ -632,6 +632,6 @@  static struct i2c_driver max30102_driver = {
 };
 module_i2c_driver(max30102_driver);
 
-MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
+MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
 MODULE_DESCRIPTION("MAX30102 heart rate/pulse oximeter and MAX30105 particle sensor driver");
 MODULE_LICENSE("GPL");