diff mbox series

[v2,07/20] dt-bindings:iio:adc:nuvoton,nau7802 yaml conversion

Message ID 20200909175946.395313-8-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings:iio:adc: Another set of yaml conversions. | expand

Commit Message

Jonathan Cameron Sept. 9, 2020, 5:59 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

A simple conversion from txt file to yaml.  I added the #io-channel-cells
property as optional to allow the channels of this ADCs to be used
to provide services to other drivers, for example if an analog
accelerometer is connected.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
 .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
 2 files changed, 50 insertions(+), 18 deletions(-)

Comments

Alexandre Belloni Sept. 9, 2020, 7:19 p.m. UTC | #1
Hi,

On 09/09/2020 18:59:33+0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> A simple conversion from txt file to yaml.  I added the #io-channel-cells
> property as optional to allow the channels of this ADCs to be used
> to provide services to other drivers, for example if an analog
> accelerometer is connected.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
>  .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
>  2 files changed, 50 insertions(+), 18 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
> new file mode 100644
> index 000000000000..bcd041ea28a8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nau7802.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NAU7802 I2c Analog to Digital Converter (ADC)
> +
> +maintainers:
> +  - Alexandre Belloni <alexandre.belloni@free-electrons.com>
> +  - Maxime Ripard <maxime.ripard@free-electrons.com>
> +

Sorry, I meant to reply earlier. Can you make that:

 - Alexandre Belloni <alexandre.belloni@bootlin.com>
 - Maxime Ripard <mripard@kernel.org>

Else, this seems good to me!

> +properties:
> +  compatible:
> +    const: nuvoton,nau7802
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  nuvoton,vldo:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Internal reference voltage in millivolts to be configured.
> +    minimum: 2400
> +    maximum: 4500
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        nau7802@2a {
> +            compatible = "nuvoton,nau7802";
> +            reg = <0x2a>;
> +            nuvoton,vldo = <3000>;
> +        };
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
> deleted file mode 100644
> index e9582e6fe350..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Nuvoton NAU7802 Analog to Digital Converter (ADC)
> -
> -Required properties:
> -  - compatible: Should be "nuvoton,nau7802"
> -  - reg: Should contain the ADC I2C address
> -
> -Optional properties:
> -  - nuvoton,vldo: Internal reference voltage in millivolts to be
> -    configured valid values are between 2400 mV and 4500 mV.
> -  - interrupts: IRQ line for the ADC. If not used the driver will use
> -    polling.
> -
> -Example:
> -adc2: nau7802@2a {
> -	compatible = "nuvoton,nau7802";
> -	reg = <0x2a>;
> -	nuvoton,vldo = <3000>;
> -};
> -- 
> 2.28.0
>
Jonathan Cameron Sept. 10, 2020, 7:57 a.m. UTC | #2
On Wed, 9 Sep 2020 21:19:23 +0200
Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:

> Hi,
> 
> On 09/09/2020 18:59:33+0100, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > A simple conversion from txt file to yaml.  I added the #io-channel-cells
> > property as optional to allow the channels of this ADCs to be used
> > to provide services to other drivers, for example if an analog
> > accelerometer is connected.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
> >  .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
> >  2 files changed, 50 insertions(+), 18 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
> > new file mode 100644
> > index 000000000000..bcd041ea28a8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nau7802.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton NAU7802 I2c Analog to Digital Converter (ADC)
> > +
> > +maintainers:
> > +  - Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > +  - Maxime Ripard <maxime.ripard@free-electrons.com>
> > +  
> 
> Sorry, I meant to reply earlier. Can you make that:
> 
>  - Alexandre Belloni <alexandre.belloni@bootlin.com>
>  - Maxime Ripard <mripard@kernel.org>
> 
> Else, this seems good to me!

Will do. If I don't do a v3 for other reasons I'll change that
whilst applying.

Thanks,

Jonathan

> 
> > +properties:
> > +  compatible:
> > +    const: nuvoton,nau7802
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  nuvoton,vldo:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      Internal reference voltage in millivolts to be configured.
> > +    minimum: 2400
> > +    maximum: 4500
> > +
> > +  "#io-channel-cells":
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        nau7802@2a {
> > +            compatible = "nuvoton,nau7802";
> > +            reg = <0x2a>;
> > +            nuvoton,vldo = <3000>;
> > +        };
> > +    };
> > +...
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
> > deleted file mode 100644
> > index e9582e6fe350..000000000000
> > --- a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
> > +++ /dev/null
> > @@ -1,18 +0,0 @@
> > -* Nuvoton NAU7802 Analog to Digital Converter (ADC)
> > -
> > -Required properties:
> > -  - compatible: Should be "nuvoton,nau7802"
> > -  - reg: Should contain the ADC I2C address
> > -
> > -Optional properties:
> > -  - nuvoton,vldo: Internal reference voltage in millivolts to be
> > -    configured valid values are between 2400 mV and 4500 mV.
> > -  - interrupts: IRQ line for the ADC. If not used the driver will use
> > -    polling.
> > -
> > -Example:
> > -adc2: nau7802@2a {
> > -	compatible = "nuvoton,nau7802";
> > -	reg = <0x2a>;
> > -	nuvoton,vldo = <3000>;
> > -};
> > -- 
> > 2.28.0
> >   
>
Rob Herring Sept. 15, 2020, 7:06 p.m. UTC | #3
On Wed, 09 Sep 2020 18:59:33 +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> A simple conversion from txt file to yaml.  I added the #io-channel-cells
> property as optional to allow the channels of this ADCs to be used
> to provide services to other drivers, for example if an analog
> accelerometer is connected.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
>  .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
>  2 files changed, 50 insertions(+), 18 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Jonathan Cameron Sept. 19, 2020, 2:01 p.m. UTC | #4
On Tue, 15 Sep 2020 13:06:16 -0600
Rob Herring <robh@kernel.org> wrote:

> On Wed, 09 Sep 2020 18:59:33 +0100, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > A simple conversion from txt file to yaml.  I added the #io-channel-cells
> > property as optional to allow the channels of this ADCs to be used
> > to provide services to other drivers, for example if an analog
> > accelerometer is connected.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
> >  .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
> >  2 files changed, 50 insertions(+), 18 deletions(-)
> >   
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied with updated email addresses as Alexandre requested.

Thanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
new file mode 100644
index 000000000000..bcd041ea28a8
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
@@ -0,0 +1,50 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/nuvoton,nau7802.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nuvoton NAU7802 I2c Analog to Digital Converter (ADC)
+
+maintainers:
+  - Alexandre Belloni <alexandre.belloni@free-electrons.com>
+  - Maxime Ripard <maxime.ripard@free-electrons.com>
+
+properties:
+  compatible:
+    const: nuvoton,nau7802
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  nuvoton,vldo:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Internal reference voltage in millivolts to be configured.
+    minimum: 2400
+    maximum: 4500
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        nau7802@2a {
+            compatible = "nuvoton,nau7802";
+            reg = <0x2a>;
+            nuvoton,vldo = <3000>;
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
deleted file mode 100644
index e9582e6fe350..000000000000
--- a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
+++ /dev/null
@@ -1,18 +0,0 @@ 
-* Nuvoton NAU7802 Analog to Digital Converter (ADC)
-
-Required properties:
-  - compatible: Should be "nuvoton,nau7802"
-  - reg: Should contain the ADC I2C address
-
-Optional properties:
-  - nuvoton,vldo: Internal reference voltage in millivolts to be
-    configured valid values are between 2400 mV and 4500 mV.
-  - interrupts: IRQ line for the ADC. If not used the driver will use
-    polling.
-
-Example:
-adc2: nau7802@2a {
-	compatible = "nuvoton,nau7802";
-	reg = <0x2a>;
-	nuvoton,vldo = <3000>;
-};