diff mbox series

[05/38] iio:potentiometer:max5481: Drop invalid ACPI binding.

Message ID 20200910173242.621168-6-jic23@kernel.org (mailing list archive)
State New
Headers show
Series iio: remaining easy of_match_ptr removal and related. | expand

Commit Message

Jonathan Cameron Sept. 10, 2020, 5:32 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Given that an ACPI binding must start with 3 or 4 capitals,
this cannot represent a valid binding.

It seems unlikely anything out there is using it.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Maury Anderson <maury.anderson@rockwellcollins.com>
Cc: Matthew Weber <matthew.weber@rockwellcollins.com>
Cc: Slawomir Stepien <sst@poczta.fm>
---
 drivers/iio/potentiometer/max5481.c | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Andy Shevchenko Sept. 14, 2020, 8:07 a.m. UTC | #1
On Thu, Sep 10, 2020 at 8:35 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Given that an ACPI binding must start with 3 or 4 capitals,
> this cannot represent a valid binding.
>
> It seems unlikely anything out there is using it.

Totally agree.
The names are dictated by the ACPI specification and don't mention
small letters.

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Maury Anderson <maury.anderson@rockwellcollins.com>
> Cc: Matthew Weber <matthew.weber@rockwellcollins.com>
> Cc: Slawomir Stepien <sst@poczta.fm>
> ---
>  drivers/iio/potentiometer/max5481.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/iio/potentiometer/max5481.c b/drivers/iio/potentiometer/max5481.c
> index 6d1e1a57cba1..a88ed0eb3adc 100644
> --- a/drivers/iio/potentiometer/max5481.c
> +++ b/drivers/iio/potentiometer/max5481.c
> @@ -7,7 +7,6 @@
>   * https://datasheets.maximintegrated.com/en/ds/MAX5481-MAX5484.pdf
>   */
>
> -#include <linux/acpi.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
>  #include <linux/module.h>
> @@ -182,22 +181,10 @@ static const struct spi_device_id max5481_id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(spi, max5481_id_table);
>
> -#if defined(CONFIG_ACPI)
> -static const struct acpi_device_id max5481_acpi_match[] = {
> -       { "max5481", max5481 },
> -       { "max5482", max5482 },
> -       { "max5483", max5483 },
> -       { "max5484", max5484 },
> -       { }
> -};
> -MODULE_DEVICE_TABLE(acpi, max5481_acpi_match);
> -#endif
> -
>  static struct spi_driver max5481_driver = {
>         .driver = {
>                 .name  = "max5481",
>                 .of_match_table = max5481_match,
> -               .acpi_match_table = ACPI_PTR(max5481_acpi_match),
>         },
>         .probe = max5481_probe,
>         .remove = max5481_remove,
> --
> 2.28.0
>
diff mbox series

Patch

diff --git a/drivers/iio/potentiometer/max5481.c b/drivers/iio/potentiometer/max5481.c
index 6d1e1a57cba1..a88ed0eb3adc 100644
--- a/drivers/iio/potentiometer/max5481.c
+++ b/drivers/iio/potentiometer/max5481.c
@@ -7,7 +7,6 @@ 
  * https://datasheets.maximintegrated.com/en/ds/MAX5481-MAX5484.pdf
  */
 
-#include <linux/acpi.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
 #include <linux/module.h>
@@ -182,22 +181,10 @@  static const struct spi_device_id max5481_id_table[] = {
 };
 MODULE_DEVICE_TABLE(spi, max5481_id_table);
 
-#if defined(CONFIG_ACPI)
-static const struct acpi_device_id max5481_acpi_match[] = {
-	{ "max5481", max5481 },
-	{ "max5482", max5482 },
-	{ "max5483", max5483 },
-	{ "max5484", max5484 },
-	{ }
-};
-MODULE_DEVICE_TABLE(acpi, max5481_acpi_match);
-#endif
-
 static struct spi_driver max5481_driver = {
 	.driver = {
 		.name  = "max5481",
 		.of_match_table = max5481_match,
-		.acpi_match_table = ACPI_PTR(max5481_acpi_match),
 	},
 	.probe = max5481_probe,
 	.remove = max5481_remove,