diff mbox series

[v2,3/5] dt-bindings: iio: ad9467: add entry for for AD9434 ADC

Message ID 20200922132559.38456-4-alexandru.ardelean@analog.com (mailing list archive)
State New, archived
Headers show
Series iio: adc: ad9467: add support for AD9434 & AD9265 | expand

Commit Message

Alexandru Ardelean Sept. 22, 2020, 1:25 p.m. UTC
Add entry for the AD9434 high-speed ADC which is supported by the 'ad9467'
driver.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron Sept. 23, 2020, 8:39 p.m. UTC | #1
On Tue, 22 Sep 2020 16:25:57 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> Add entry for the AD9434 high-speed ADC which is supported by the 'ad9467'
> driver.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

Probably want to tweak a few other bits of the binding.
It has some specific statements about the ad9467 as this is only
second device to be added.  Need to change to those to "ad9467 and similar"
or something like that + add description for this part.

> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> index c4f57fa6aad1..0e8da8ee6975 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> @@ -19,6 +19,7 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - adi,ad9434
>        - adi,ad9467
>  
>    reg:
Alexandru Ardelean Sept. 24, 2020, 7:37 a.m. UTC | #2
On Wed, Sep 23, 2020 at 11:42 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Tue, 22 Sep 2020 16:25:57 +0300
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
> > Add entry for the AD9434 high-speed ADC which is supported by the 'ad9467'
> > driver.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Probably want to tweak a few other bits of the binding.
> It has some specific statements about the ad9467 as this is only
> second device to be added.  Need to change to those to "ad9467 and similar"
> or something like that + add description for this part.

Yep, that was sloppy on my part.
Will update.

>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> > index c4f57fa6aad1..0e8da8ee6975 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> > @@ -19,6 +19,7 @@ description: |
> >  properties:
> >    compatible:
> >      enum:
> > +      - adi,ad9434
> >        - adi,ad9467
> >
> >    reg:
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
index c4f57fa6aad1..0e8da8ee6975 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
@@ -19,6 +19,7 @@  description: |
 properties:
   compatible:
     enum:
+      - adi,ad9434
       - adi,ad9467
 
   reg: