| Message ID | 20200924195215.49443-3-michael.auchter@ni.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/3] iio: dac: ad5686: add support for AD5338R | expand |
On Thu, 24 Sep 2020 14:52:14 -0500 Michael Auchter <michael.auchter@ni.com> wrote: > Add a binding for AD5686 > > Signed-off-by: Michael Auchter <michael.auchter@ni.com> Hi Michael, Looks good to me, but I've made many a mistake on reviewing these in the past so good to get Rob's input if he has time. Thanks, Jonathan > --- > Changes since v1: > - Keep supported device sorted > - fix adc -> dac typo in schema path > since v2: > - drop address-cells and size-cells from binding doc > - add "additionalProperties: false" > - end with ... > > .../bindings/iio/dac/adi,ad5686.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > new file mode 100644 > index 000000000000..8065228e5df8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD5686 and similar multi-channel DACs > + > +maintainers: > + - Michael Auchter <michael.auchter@ni.com> > + > +description: | > + Binding for Analog Devices AD5686 and similar multi-channel DACs > + > +properties: > + compatible: > + enum: > + - adi,ad5311r > + - adi,ad5338r > + - adi,ad5671r > + - adi,ad5675r > + - adi,ad5691r > + - adi,ad5692r > + - adi,ad5693 > + - adi,ad5693r > + - adi,ad5694 > + - adi,ad5694r > + - adi,ad5695r > + - adi,ad5696 > + - adi,ad5696r > + > + reg: > + maxItems: 1 > + > + vcc-supply: > + description: | > + The regulator supply for DAC reference voltage. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ad5686: dac@0 { > + compatible = "adi,ad5686"; > + reg = <0>; > + vcc-supply = <&dac_vref>; > + }; > + }; > +...
On Thu, 24 Sep 2020 14:52:14 -0500, Michael Auchter wrote: > Add a binding for AD5686 > > Signed-off-by: Michael Auchter <michael.auchter@ni.com> > --- > Changes since v1: > - Keep supported device sorted > - fix adc -> dac typo in schema path > since v2: > - drop address-cells and size-cells from binding doc > - add "additionalProperties: false" > - end with ... > > .../bindings/iio/dac/adi,ad5686.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, 29 Sep 2020 13:53:00 -0500 Rob Herring <robh@kernel.org> wrote: > On Thu, 24 Sep 2020 14:52:14 -0500, Michael Auchter wrote: > > Add a binding for AD5686 > > > > Signed-off-by: Michael Auchter <michael.auchter@ni.com> > > --- > > Changes since v1: > > - Keep supported device sorted > > - fix adc -> dac typo in schema path > > since v2: > > - drop address-cells and size-cells from binding doc > > - add "additionalProperties: false" > > - end with ... > > > > .../bindings/iio/dac/adi,ad5686.yaml | 57 +++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml > > > > Reviewed-by: Rob Herring <robh@kernel.org> Series applied with a slight tweak to patch 1 to constify the channel macro inline with recent tidy up patch doing the same to other instances in the driver. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it and see if we missed anything. Thanks, Jonathan
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml new file mode 100644 index 000000000000..8065228e5df8 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD5686 and similar multi-channel DACs + +maintainers: + - Michael Auchter <michael.auchter@ni.com> + +description: | + Binding for Analog Devices AD5686 and similar multi-channel DACs + +properties: + compatible: + enum: + - adi,ad5311r + - adi,ad5338r + - adi,ad5671r + - adi,ad5675r + - adi,ad5691r + - adi,ad5692r + - adi,ad5693 + - adi,ad5693r + - adi,ad5694 + - adi,ad5694r + - adi,ad5695r + - adi,ad5696 + - adi,ad5696r + + reg: + maxItems: 1 + + vcc-supply: + description: | + The regulator supply for DAC reference voltage. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ad5686: dac@0 { + compatible = "adi,ad5686"; + reg = <0>; + vcc-supply = <&dac_vref>; + }; + }; +...
Add a binding for AD5686 Signed-off-by: Michael Auchter <michael.auchter@ni.com> --- Changes since v1: - Keep supported device sorted - fix adc -> dac typo in schema path since v2: - drop address-cells and size-cells from binding doc - add "additionalProperties: false" - end with ... .../bindings/iio/dac/adi,ad5686.yaml | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml