diff mbox series

[2/2] iio: adc: ad7298: check regulator for null in ad7298_get_ref_voltage()

Message ID 20201127094038.91714-2-alexandru.ardelean@analog.com (mailing list archive)
State New
Headers show
Series [1/2] iio: adc: ad7298: convert probe to device-managed functions | expand

Commit Message

Alexandru Ardelean Nov. 27, 2020, 9:40 a.m. UTC
'st->ext_ref' & 'st->reg' are both non-zero/non-null at the same time, so
logically the code isn't broken.
But it is more correct to check that 'st->reg' is non-null, since we make
sure that the regulator is NULL (in probe) in case one isn't defined.

Cc: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
 drivers/iio/adc/ad7298.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c
index ecdb01bd5b2f..689ecd5dd563 100644
--- a/drivers/iio/adc/ad7298.c
+++ b/drivers/iio/adc/ad7298.c
@@ -214,7 +214,7 @@  static int ad7298_get_ref_voltage(struct ad7298_state *st)
 	int vref;
-	if (st->ext_ref) {
+	if (st->reg) {
 		vref = regulator_get_voltage(st->reg);
 		if (vref < 0)
 			return vref;