diff mbox series

[1/2] iio: magnetometer: yas530: Fix return value on errorpath

Message ID 20210215153023.47899-1-linus.walleij@linaro.org (mailing list archive)
State New
Headers show
Series [1/2] iio: magnetometer: yas530: Fix return value on errorpath | expand

Commit Message

Linus Walleij Feb. 15, 2021, 3:30 p.m. UTC
There was a missed return variable assignment in the
default errorpath of the switch statement in yas5xx_probe().
Fix it.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/iio/magnetometer/yamaha-yas530.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron Feb. 21, 2021, 3:45 p.m. UTC | #1
On Mon, 15 Feb 2021 16:30:23 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> There was a missed return variable assignment in the
> default errorpath of the switch statement in yas5xx_probe().
> Fix it.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Hi Linus,

A bit of bad timing on these.  I'm running behind on pull requests for
my fixes-togreg branch so it doesn't yet have the driver.

Hence I'll pick these up in a couple of weeks once that's rebased after
I send Greg a pull request.

Give me a poke if I seem to have forgotten them.

Thanks,

Jonathan

> ---
>  drivers/iio/magnetometer/yamaha-yas530.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
> index d46f23d82b3d..cee6207d8847 100644
> --- a/drivers/iio/magnetometer/yamaha-yas530.c
> +++ b/drivers/iio/magnetometer/yamaha-yas530.c
> @@ -887,6 +887,7 @@ static int yas5xx_probe(struct i2c_client *i2c,
>  		strncpy(yas5xx->name, "yas532", sizeof(yas5xx->name));
>  		break;
>  	default:
> +		ret = -ENODEV;
>  		dev_err(dev, "unhandled device ID %02x\n", yas5xx->devid);
>  		goto assert_reset;
>  	}
Linus Walleij March 1, 2021, 9 a.m. UTC | #2
On Sun, Feb 21, 2021 at 4:45 PM Jonathan Cameron <jic23@kernel.org> wrote:

> A bit of bad timing on these.  I'm running behind on pull requests for
> my fixes-togreg branch so it doesn't yet have the driver.
>
> Hence I'll pick these up in a couple of weeks once that's rebased after
> I send Greg a pull request.
>
> Give me a poke if I seem to have forgotten them.

No problem, the fixes are not critical in any way.
I'll track them!

Yours,
Linus Walleij
Jonathan Cameron March 22, 2021, 7:51 p.m. UTC | #3
On Mon, 1 Mar 2021 10:00:35 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Sun, Feb 21, 2021 at 4:45 PM Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > A bit of bad timing on these.  I'm running behind on pull requests for
> > my fixes-togreg branch so it doesn't yet have the driver.
> >
> > Hence I'll pick these up in a couple of weeks once that's rebased after
> > I send Greg a pull request.
> >
> > Give me a poke if I seem to have forgotten them.  
> 
> No problem, the fixes are not critical in any way.
> I'll track them!
> 
Series applied to the fixes-togreg branch of iio.git.

Apologies for the delay.

Jonathan

> Yours,
> Linus Walleij
diff mbox series

Patch

diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
index d46f23d82b3d..cee6207d8847 100644
--- a/drivers/iio/magnetometer/yamaha-yas530.c
+++ b/drivers/iio/magnetometer/yamaha-yas530.c
@@ -887,6 +887,7 @@  static int yas5xx_probe(struct i2c_client *i2c,
 		strncpy(yas5xx->name, "yas532", sizeof(yas5xx->name));
 		break;
 	default:
+		ret = -ENODEV;
 		dev_err(dev, "unhandled device ID %02x\n", yas5xx->devid);
 		goto assert_reset;
 	}