diff mbox series

[2/2] dt-bindings: vcnl3020: add proximity rate in hz

Message ID 20210216145346.18304-3-i.mikhaylov@yadro.com (mailing list archive)
State New
Headers show
Series add proximity rate option for vcnl3020 | expand

Commit Message

Ivan Mikhaylov Feb. 16, 2021, 2:53 p.m. UTC
Describe the possible proximity values in herzes for vcnl3020.

Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
---
 .../devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml  | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jonathan Cameron Feb. 21, 2021, 3:09 p.m. UTC | #1
On Tue, 16 Feb 2021 17:53:46 +0300
Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:

> Describe the possible proximity values in herzes for vcnl3020.
Hertz

Why does this belong in DT?

DT bindings should reflect physical characteristics of the device, so how
is wired up, whether there are plastic windows over it that might affect
calibration - that sort of thing.   A rate of sampling proximity seems
like a policy decision best left to user space.

Jonathan

> 
> Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
> ---
>  .../devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml  | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> index fbd3a2e32280..1bb6ca1770f3 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> @@ -43,6 +43,12 @@ properties:
>             180000, 190000, 200000]
>      default: 20000
>  
> +  vishay,proximity-rate-hz:
> +    description:
> +      The rate of proximity measurement.
> +    enum: [1, 3, 7, 16, 31, 62, 125, 500]
> +    default: 1
> +
>  required:
>    - compatible
>    - reg
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
index fbd3a2e32280..1bb6ca1770f3 100644
--- a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
@@ -43,6 +43,12 @@  properties:
            180000, 190000, 200000]
     default: 20000
 
+  vishay,proximity-rate-hz:
+    description:
+      The rate of proximity measurement.
+    enum: [1, 3, 7, 16, 31, 62, 125, 500]
+    default: 1
+
 required:
   - compatible
   - reg