| Message ID | 20210309193620.2176163-7-gwendal@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: Set default trigger device parent | expand |
On Tue, Mar 9, 2021 at 11:37 AM Gwendal Grignou <gwendal@chromium.org> wrote: > > iio_trigger_set_drvdata() sets the trigger device parent to first > argument of viio_trigger_alloc(), no need to do it again in the driver > code. > > Given we call devm_iio_trigger_alloc() and devm_iio_device_alloc() with > &client->dev as parent, we do not have to set data->trig->dev.parent to > indio_dev->dev.parent anymore. > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com> > --- > Changes in v4: > Improve commit message. > > No changes in v3. > > drivers/iio/chemical/atlas-sensor.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c > index cdab9d04dedd0..56ba6c82b501f 100644 > --- a/drivers/iio/chemical/atlas-sensor.c > +++ b/drivers/iio/chemical/atlas-sensor.c > @@ -649,7 +649,6 @@ static int atlas_probe(struct i2c_client *client, > data->client = client; > data->trig = trig; > data->chip = chip; > - trig->dev.parent = indio_dev->dev.parent; > trig->ops = &atlas_interrupt_trigger_ops; > iio_trigger_set_drvdata(trig, indio_dev); > > -- > 2.30.1.766.gb4fecdf3b7-goog >
diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c index cdab9d04dedd0..56ba6c82b501f 100644 --- a/drivers/iio/chemical/atlas-sensor.c +++ b/drivers/iio/chemical/atlas-sensor.c @@ -649,7 +649,6 @@ static int atlas_probe(struct i2c_client *client, data->client = client; data->trig = trig; data->chip = chip; - trig->dev.parent = indio_dev->dev.parent; trig->ops = &atlas_interrupt_trigger_ops; iio_trigger_set_drvdata(trig, indio_dev);
iio_trigger_set_drvdata() sets the trigger device parent to first argument of viio_trigger_alloc(), no need to do it again in the driver code. Given we call devm_iio_trigger_alloc() and devm_iio_device_alloc() with &client->dev as parent, we do not have to set data->trig->dev.parent to indio_dev->dev.parent anymore. Signed-off-by: Gwendal Grignou <gwendal@chromium.org> --- Changes in v4: Improve commit message. No changes in v3. drivers/iio/chemical/atlas-sensor.c | 1 - 1 file changed, 1 deletion(-)