diff mbox series

iio:accel:adis16201: Fix wrong axis assignment that prevents loading

Message ID 20210321182956.844652-1-jic23@kernel.org (mailing list archive)
State New
Headers show
Series iio:accel:adis16201: Fix wrong axis assignment that prevents loading | expand

Commit Message

Jonathan Cameron March 21, 2021, 6:29 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Whilst running some basic tests as part of writing up the dt-bindings for
this driver (to follow), it became clear it doesn't actually load
currently.

iio iio:device1: tried to double register : in_incli_x_index
adis16201 spi0.0: Failed to create buffer sysfs interfaces
adis16201: probe of spi0.0 failed with error -16

Looks like a cut and paste / update bug.  Fixes tag obviously not accurate
but we don't want to bother carry thing back to before the driver moved
out of staging.

Fixes: 591298e54cea ("Staging: iio: accel: adis16201: Move adis16201 driver out of staging")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Himanshu Jha <himanshujha199640@gmail.com>
Cc: Nuno Sá <nuno.sa@analog.com>
---
 drivers/iio/accel/adis16201.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandru Ardelean March 22, 2021, 7:43 a.m. UTC | #1
On Sun, Mar 21, 2021 at 8:34 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Whilst running some basic tests as part of writing up the dt-bindings for
> this driver (to follow), it became clear it doesn't actually load
> currently.
>
> iio iio:device1: tried to double register : in_incli_x_index
> adis16201 spi0.0: Failed to create buffer sysfs interfaces
> adis16201: probe of spi0.0 failed with error -16
>
> Looks like a cut and paste / update bug.  Fixes tag obviously not accurate
> but we don't want to bother carry thing back to before the driver moved
> out of staging.
>

Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>

> Fixes: 591298e54cea ("Staging: iio: accel: adis16201: Move adis16201 driver out of staging")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Himanshu Jha <himanshujha199640@gmail.com>
> Cc: Nuno Sá <nuno.sa@analog.com>
> ---
>  drivers/iio/accel/adis16201.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
> index 3633a4e302c6..fe225990de24 100644
> --- a/drivers/iio/accel/adis16201.c
> +++ b/drivers/iio/accel/adis16201.c
> @@ -215,7 +215,7 @@ static const struct iio_chan_spec adis16201_channels[] = {
>         ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12),
>         ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X,
>                         BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
> -       ADIS_INCLI_CHAN(X, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
> +       ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
>                         BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
>         IIO_CHAN_SOFT_TIMESTAMP(7)
>  };
> --
> 2.31.0
>
Jonathan Cameron March 29, 2021, 10:15 a.m. UTC | #2
On Mon, 22 Mar 2021 09:43:57 +0200
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Sun, Mar 21, 2021 at 8:34 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Whilst running some basic tests as part of writing up the dt-bindings for
> > this driver (to follow), it became clear it doesn't actually load
> > currently.
> >
> > iio iio:device1: tried to double register : in_incli_x_index
> > adis16201 spi0.0: Failed to create buffer sysfs interfaces
> > adis16201: probe of spi0.0 failed with error -16
> >
> > Looks like a cut and paste / update bug.  Fixes tag obviously not accurate
> > but we don't want to bother carry thing back to before the driver moved
> > out of staging.
> >  
> 
> Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Give this has been broken a while I'm not going to rush it it as a
fix.  Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it.

Thanks,

Jonathan

> 
> > Fixes: 591298e54cea ("Staging: iio: accel: adis16201: Move adis16201 driver out of staging")
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Himanshu Jha <himanshujha199640@gmail.com>
> > Cc: Nuno Sá <nuno.sa@analog.com>
> > ---
> >  drivers/iio/accel/adis16201.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
> > index 3633a4e302c6..fe225990de24 100644
> > --- a/drivers/iio/accel/adis16201.c
> > +++ b/drivers/iio/accel/adis16201.c
> > @@ -215,7 +215,7 @@ static const struct iio_chan_spec adis16201_channels[] = {
> >         ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12),
> >         ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X,
> >                         BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
> > -       ADIS_INCLI_CHAN(X, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
> > +       ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
> >                         BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
> >         IIO_CHAN_SOFT_TIMESTAMP(7)
> >  };
> > --
> > 2.31.0
> >
diff mbox series

Patch

diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
index 3633a4e302c6..fe225990de24 100644
--- a/drivers/iio/accel/adis16201.c
+++ b/drivers/iio/accel/adis16201.c
@@ -215,7 +215,7 @@  static const struct iio_chan_spec adis16201_channels[] = {
 	ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12),
 	ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X,
 			BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
-	ADIS_INCLI_CHAN(X, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
+	ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
 			BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
 	IIO_CHAN_SOFT_TIMESTAMP(7)
 };