diff mbox series

[1/2] iio: inv_mpu6050: Remove superfluous indio_dev->modes assignment

Message ID 20210325131046.13383-1-lars@metafoo.de (mailing list archive)
State New
Headers show
Series [1/2] iio: inv_mpu6050: Remove superfluous indio_dev->modes assignment | expand

Commit Message

Lars-Peter Clausen March 25, 2021, 1:10 p.m. UTC
The inv_mpu6050 driver manually assigns the indio_dev->modes property. But
this is not necessary since it will be setup in iio_trigger_buffer_setup().

Remove the manual assignment.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Linus Walleij March 25, 2021, 2:32 p.m. UTC | #1
On Thu, Mar 25, 2021 at 2:10 PM Lars-Peter Clausen <lars@metafoo.de> wrote:

> The inv_mpu6050 driver manually assigns the indio_dev->modes property. But
> this is not necessary since it will be setup in iio_trigger_buffer_setup().
>
> Remove the manual assignment.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

The word "manual" confuse me as much as usual when it comes
to a computer program and makes me look for the man doing the
manual work, but I guess you mean "imperatively" which is a word
noone uses.
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Jean-Baptiste Maneyrol March 25, 2021, 5:10 p.m. UTC | #2
Hello,

thanks for the patch,
JB

Acked-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>


From: Lars-Peter Clausen <lars@metafoo.de>
Sent: Thursday, March 25, 2021 14:10
To: Jonathan Cameron <jic23@kernel.org>
Cc: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>; Linus Walleij <linus.walleij@linaro.org>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 1/2] iio: inv_mpu6050: Remove superfluous indio_dev->modes assignment 
 
 CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.

The inv_mpu6050 driver manually assigns the indio_dev->modes property. But
this is not necessary since it will be setup in iio_trigger_buffer_setup().

Remove the manual assignment.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index 453c51c79655..99ee0a218875 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -1591,7 +1591,6 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name,
         }
 
         indio_dev->info = &mpu_info;
-       indio_dev->modes = INDIO_BUFFER_TRIGGERED;
 
         result = devm_iio_triggered_buffer_setup(dev, indio_dev,
                                                  iio_pollfunc_store_time,
Jonathan Cameron March 29, 2021, 12:35 p.m. UTC | #3
On Thu, 25 Mar 2021 14:10:45 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:

> The inv_mpu6050 driver manually assigns the indio_dev->modes property. But
> this is not necessary since it will be setup in iio_trigger_buffer_setup().
> 
> Remove the manual assignment.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Both applied to the togreg branch of iio.git and pushed out as testing fo the
autobuilders to poke at it.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 453c51c79655..99ee0a218875 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -1591,7 +1591,6 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name,
>  	}
>  
>  	indio_dev->info = &mpu_info;
> -	indio_dev->modes = INDIO_BUFFER_TRIGGERED;
>  
>  	result = devm_iio_triggered_buffer_setup(dev, indio_dev,
>  						 iio_pollfunc_store_time,
diff mbox series

Patch

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index 453c51c79655..99ee0a218875 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -1591,7 +1591,6 @@  int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name,
 	}
 
 	indio_dev->info = &mpu_info;
-	indio_dev->modes = INDIO_BUFFER_TRIGGERED;
 
 	result = devm_iio_triggered_buffer_setup(dev, indio_dev,
 						 iio_pollfunc_store_time,