diff mbox series

iio:accel:stk8312: Add lowercase i2c device id

Message ID 20210401144226.225928-1-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series iio:accel:stk8312: Add lowercase i2c device id | expand

Commit Message

Jonathan Cameron April 1, 2021, 2:42 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

These are never upper case.  Chances are that all users of this driver
were using the ACPI binding but just in case keep the uppercase version
but mark it deprecated.

Whilst here tidy up some spacing.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/accel/stk8312.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron April 24, 2021, 5:22 p.m. UTC | #1
On Thu,  1 Apr 2021 15:42:26 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> These are never upper case.  Chances are that all users of this driver
> were using the ACPI binding but just in case keep the uppercase version
> but mark it deprecated.
> 
> Whilst here tidy up some spacing.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
I'm not going to pester anyone about reviewing this given how trivial it is.

Hence applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it and prove it's not as trivial as I'm assuming ;(

Jonathan

> ---
>  drivers/iio/accel/stk8312.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
> index 157d8faefb9e..60aecfa9fd92 100644
> --- a/drivers/iio/accel/stk8312.c
> +++ b/drivers/iio/accel/stk8312.c
> @@ -635,13 +635,15 @@ static SIMPLE_DEV_PM_OPS(stk8312_pm_ops, stk8312_suspend, stk8312_resume);
>  #endif
>  
>  static const struct i2c_device_id stk8312_i2c_id[] = {
> -	{"STK8312", 0},
> +	/* Deprecated in favour of lowercase form */
> +	{ "STK8312", 0 },
> +	{ "stk8312", 0 },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id);
>  
>  static const struct acpi_device_id stk8312_acpi_id[] = {
> -	{"STK8312", 0},
> +	{ "STK8312", 0 },
>  	{}
>  };
>
diff mbox series

Patch

diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
index 157d8faefb9e..60aecfa9fd92 100644
--- a/drivers/iio/accel/stk8312.c
+++ b/drivers/iio/accel/stk8312.c
@@ -635,13 +635,15 @@  static SIMPLE_DEV_PM_OPS(stk8312_pm_ops, stk8312_suspend, stk8312_resume);
 #endif
 
 static const struct i2c_device_id stk8312_i2c_id[] = {
-	{"STK8312", 0},
+	/* Deprecated in favour of lowercase form */
+	{ "STK8312", 0 },
+	{ "stk8312", 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id);
 
 static const struct acpi_device_id stk8312_acpi_id[] = {
-	{"STK8312", 0},
+	{ "STK8312", 0 },
 	{}
 };