diff mbox series

iio:cdc:ad7150: Fix use of uninitialized ret

Message ID 20210406083244.649984-1-jic23@kernel.org (mailing list archive)
State New
Headers show
Series iio:cdc:ad7150: Fix use of uninitialized ret | expand

Commit Message

Jonathan Cameron April 6, 2021, 8:32 a.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This doesn't appear to generate a warning on all versions of GCC, but
0-day reported it and the report looks valid.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reported-by: kbuild test robot <lkp@intel.com>
---
 drivers/iio/cdc/ad7150.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron April 6, 2021, 8:44 a.m. UTC | #1
On Tue,  6 Apr 2021 09:32:44 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> This doesn't appear to generate a warning on all versions of GCC, but
> 0-day reported it and the report looks valid.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reported-by: kbuild test robot <lkp@intel.com>

For this one, it's the sort of thing I'd normally just roll into the original
patch, but there is a merge in my tree after this, so in the interests of
simplicity I've applied it on top.

Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to take another look at it and see what I got wrong this time :)

Jonathan

> ---
>  drivers/iio/cdc/ad7150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/cdc/ad7150.c b/drivers/iio/cdc/ad7150.c
> index f9cce1a64586..ebe112b4618b 100644
> --- a/drivers/iio/cdc/ad7150.c
> +++ b/drivers/iio/cdc/ad7150.c
> @@ -235,7 +235,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,
>  				     enum iio_event_direction dir, int state)
>  {
>  	struct ad7150_chip_info *chip = iio_priv(indio_dev);
> -	int ret;
> +	int ret = 0;
>  
>  	/*
>  	 * There is only a single shared control and no on chip
diff mbox series

Patch

diff --git a/drivers/iio/cdc/ad7150.c b/drivers/iio/cdc/ad7150.c
index f9cce1a64586..ebe112b4618b 100644
--- a/drivers/iio/cdc/ad7150.c
+++ b/drivers/iio/cdc/ad7150.c
@@ -235,7 +235,7 @@  static int ad7150_write_event_config(struct iio_dev *indio_dev,
 				     enum iio_event_direction dir, int state)
 {
 	struct ad7150_chip_info *chip = iio_priv(indio_dev);
-	int ret;
+	int ret = 0;
 
 	/*
 	 * There is only a single shared control and no on chip