| Message ID | 20210407045938.29129-1-dinghao.liu@zju.edu.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: proximity: pulsedlight: Fix rumtime PM imbalance on error | expand |
On Wed, Apr 7, 2021 at 7:59 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote: > > When lidar_write_control() fails, a pairing PM usage counter > decrement is needed to keep the counter balanced. FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > index c685f10b5ae4..cc206bfa09c7 100644 > --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > @@ -160,6 +160,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg) > ret = lidar_write_control(data, LIDAR_REG_CONTROL_ACQUIRE); > if (ret < 0) { > dev_err(&client->dev, "cannot send start measurement command"); > + pm_runtime_put_noidle(&client->dev); > return ret; > } > > -- > 2.17.1 >
On Wed, 7 Apr 2021 12:59:35 +0800 Dinghao Liu <dinghao.liu@zju.edu.cn> wrote: > When lidar_write_control() fails, a pairing PM usage counter > decrement is needed to keep the counter balanced. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Hi, patch content looks good but it needs a fixes tag so we know how far to backport it. Please add for v2. Thanks, Jonathan > --- > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > index c685f10b5ae4..cc206bfa09c7 100644 > --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c > @@ -160,6 +160,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg) > ret = lidar_write_control(data, LIDAR_REG_CONTROL_ACQUIRE); > if (ret < 0) { > dev_err(&client->dev, "cannot send start measurement command"); > + pm_runtime_put_noidle(&client->dev); > return ret; > } >
diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c index c685f10b5ae4..cc206bfa09c7 100644 --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c @@ -160,6 +160,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg) ret = lidar_write_control(data, LIDAR_REG_CONTROL_ACQUIRE); if (ret < 0) { dev_err(&client->dev, "cannot send start measurement command"); + pm_runtime_put_noidle(&client->dev); return ret; }
When lidar_write_control() fails, a pairing PM usage counter decrement is needed to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 + 1 file changed, 1 insertion(+)