| Message ID | 20210415114614.1071928-2-sean@geanix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC,1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers | expand |
On Thu, 15 Apr 2021 13:46:14 +0200, Sean Nyekjaer wrote: > Add devicetree binding for the NXP FXLS8962AF/FXLS8962AF > accelerometer sensor. > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > --- > .../bindings/iio/accel/nxp,fxls8962af.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.example.dts:25.33-34 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:377: Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1414: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1466588 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Thu, Apr 15, 2021 at 01:46:14PM +0200, Sean Nyekjaer wrote: > Add devicetree binding for the NXP FXLS8962AF/FXLS8962AF > accelerometer sensor. > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > --- > .../bindings/iio/accel/nxp,fxls8962af.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml > new file mode 100644 > index 000000000000..8cf099c75d1f > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/nxp,fxls8962af.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP FXLS8962AF/FXLS8964AF Accelerometer driver > + > +maintainers: > + - Sean Nyekjaer <sean@geanix.com> > + > +description: | > + NXP FXLS8962AF/FXLS8964AF Accelerometer driver that supports > + SPI and I2C interface. > + https://www.nxp.com/docs/en/data-sheet/FXLS8962AF.pdf > + https://www.nxp.com/docs/en/data-sheet/FXLS8964AF.pdf > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: nxp,fxls8962af > + - const: nxp,fxls8964af > + - enum: > + - nxp,fxls8962af > + - nxp,fxls8964af That's needlessly complicated. Either nxp,fxls8962af has a fallback or it doesn't. blank line needed here too. > + reg: > + maxItems: 1 > + > + vdd-supply: > + description: phandle to the regulator that provides power to the accelerometer > + > + spi-max-frequency: true > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { > + /* Example for a I2C device node */ > + accelerometer@2a { > + compatible = "nxp,fxls8962af"; > + reg = <0x62>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + - | > + spi0 { > + /* Example for a SPI device node */ > + accelerometer@0 { > + compatible = "nxp,fxls8962af"; > + reg = <0>; > + spi-max-frequency = <4000000>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > -- > 2.31.0 >
diff --git a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml new file mode 100644 index 000000000000..8cf099c75d1f --- /dev/null +++ b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/nxp,fxls8962af.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP FXLS8962AF/FXLS8964AF Accelerometer driver + +maintainers: + - Sean Nyekjaer <sean@geanix.com> + +description: | + NXP FXLS8962AF/FXLS8964AF Accelerometer driver that supports + SPI and I2C interface. + https://www.nxp.com/docs/en/data-sheet/FXLS8962AF.pdf + https://www.nxp.com/docs/en/data-sheet/FXLS8964AF.pdf + +properties: + compatible: + oneOf: + - items: + - const: nxp,fxls8962af + - const: nxp,fxls8964af + - enum: + - nxp,fxls8962af + - nxp,fxls8964af + reg: + maxItems: 1 + + vdd-supply: + description: phandle to the regulator that provides power to the accelerometer + + spi-max-frequency: true + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + i2c0 { + /* Example for a I2C device node */ + accelerometer@2a { + compatible = "nxp,fxls8962af"; + reg = <0x62>; + interrupt-parent = <&gpio0>; + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + }; + }; + - | + spi0 { + /* Example for a SPI device node */ + accelerometer@0 { + compatible = "nxp,fxls8962af"; + reg = <0>; + spi-max-frequency = <4000000>; + interrupt-parent = <&gpio0>; + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + }; + };
Add devicetree binding for the NXP FXLS8962AF/FXLS8962AF accelerometer sensor. Signed-off-by: Sean Nyekjaer <sean@geanix.com> --- .../bindings/iio/accel/nxp,fxls8962af.yaml | 66 +++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml