| Message ID | 20210524140536.116224-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [-next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set | expand |
On Mon, 24 May 2021 14:05:36 +0000 Wei Yongjun <weiyongjun1@huawei.com> wrote: > Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set: > > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer': > iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext' > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ': > iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup' > > Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER. > > Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Thanks, Applied to the fixes-togreg branch of iio.git. Jonathan > --- > drivers/iio/dummy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig > index 5c5c2f8c55f3..1f46cb9e51b7 100644 > --- a/drivers/iio/dummy/Kconfig > +++ b/drivers/iio/dummy/Kconfig > @@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER > select IIO_BUFFER > select IIO_TRIGGER > select IIO_KFIFO_BUF > + select IIO_TRIGGERED_BUFFER > help > Add buffered data capture to the simple dummy driver. > >
On Wed, 26 May 2021 18:00:18 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > On Mon, 24 May 2021 14:05:36 +0000 > Wei Yongjun <weiyongjun1@huawei.com> wrote: > > > Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set: > > > > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer': > > iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext' > > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ': > > iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup' > > > > Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER. > > > > Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls") > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > Thanks, > > Applied to the fixes-togreg branch of iio.git. Change of plan on this one as I haven't yet sent a fixes pull and now we are late in the cycle. I've moved it over to my togreg branch and will line it up for the coming merge window. Sorry for the delay Jonathan > > Jonathan > > > --- > > drivers/iio/dummy/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig > > index 5c5c2f8c55f3..1f46cb9e51b7 100644 > > --- a/drivers/iio/dummy/Kconfig > > +++ b/drivers/iio/dummy/Kconfig > > @@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER > > select IIO_BUFFER > > select IIO_TRIGGER > > select IIO_KFIFO_BUF > > + select IIO_TRIGGERED_BUFFER > > help > > Add buffered data capture to the simple dummy driver. > > > > >
diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig index 5c5c2f8c55f3..1f46cb9e51b7 100644 --- a/drivers/iio/dummy/Kconfig +++ b/drivers/iio/dummy/Kconfig @@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER select IIO_BUFFER select IIO_TRIGGER select IIO_KFIFO_BUF + select IIO_TRIGGERED_BUFFER help Add buffered data capture to the simple dummy driver.
Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set: riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer': iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext' riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ': iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup' Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER. Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/iio/dummy/Kconfig | 1 + 1 file changed, 1 insertion(+)