diff mbox series

[v2,3/4] iio: ltr501: ltr501_read_ps(): add missing endianness conversion

Message ID 20210610134619.2101372-4-mkl@pengutronix.de (mailing list archive)
State Accepted
Headers show
Series fix regmap, initialization of ltr559, endianness and mark structs as const | expand

Commit Message

Marc Kleine-Budde June 10, 2021, 1:46 p.m. UTC
From: Oliver Lang <Oliver.Lang@gossenmetrawatt.com>

The PS ADC Channel data is spread over 2 registers in little-endian
form. This patch adds the missing endianness conversion.

Fixes: 2690be905123 ("iio: Add Lite-On ltr501 ambient light / proximity sensor driver")
Signed-off-by: Oliver Lang <Oliver.Lang@gossenmetrawatt.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Changes since v1:
- move endianness conversion ltr501_read_ps()

 drivers/iio/light/ltr501.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox series


diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
index 79898b72fe73..74ed2d88a3ed 100644
--- a/drivers/iio/light/ltr501.c
+++ b/drivers/iio/light/ltr501.c
@@ -409,18 +409,19 @@  static int ltr501_read_als(const struct ltr501_data *data, __le16 buf[2])
 static int ltr501_read_ps(const struct ltr501_data *data)
-	int ret, status;
+	__le16 status;
+	int ret;
 	ret = ltr501_drdy(data, LTR501_STATUS_PS_RDY);
 	if (ret < 0)
 		return ret;
 	ret = regmap_bulk_read(data->regmap, LTR501_PS_DATA,
-			       &status, 2);
+			       &status, sizeof(status));
 	if (ret < 0)
 		return ret;
-	return status;
+	return le16_to_cpu(status);
 static int ltr501_read_intr_prst(const struct ltr501_data *data,