From patchwork Mon Jun 14 11:34:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 12318665 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA57C49EA2 for ; Mon, 14 Jun 2021 11:35:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1AC761166 for ; Mon, 14 Jun 2021 11:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235292AbhFNLhY (ORCPT ); Mon, 14 Jun 2021 07:37:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:58730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233249AbhFNLfX (ORCPT ); Mon, 14 Jun 2021 07:35:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D123B61209; Mon, 14 Jun 2021 11:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623670401; bh=DGEJhZj0RNHztUBk54pVFKT/l8A/xuK64FSh/emWbrE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LpQNKOz0rJYJasV7V+HjOCpDjppJddjTx3HiNAKqXNk+qlv+snnBIdLIEI3inI78c 5bPK1Cp+JOvYlCx8dbWJ3KO0xflDEeVcvIpnsSlu1InFCk1uX4xxdc8OIkQIloowRv NfxCHaUmBcqggAakxnUtQLLCbo+mxUEcL3imXiTPCQRvoNSlv/ALLFvkqVXRqaqhy6 MLbTxNmE12+sfbg3TBlGkiYHb+5OdJ67LjQBU8o4cGXLWzXS/Cl34IasKGxXyzxdPp wD3kRBhrKvmHbHbx7Ccw8Gi58MABYHhXM+F9Otg5cb6iFcNfoDA3zopeEf27hX/Oog N561Uo69/Kuhg== From: Jonathan Cameron To: linux-iio@vger.kernel.org, Rob Herring Cc: Michael.Hennerich@analog.com, lars@metafoo.de, devicetree@vger.kernel.org, Nuno Sa , Jonathan Cameron Subject: [PATCH 01/17] staging:iio:adc:ad7280a: Fix handing of device address bit reversing. Date: Mon, 14 Jun 2021 12:34:51 +0100 Message-Id: <20210614113507.897732-2-jic23@kernel.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210614113507.897732-1-jic23@kernel.org> References: <20210614113507.897732-1-jic23@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Jonathan Cameron The bit reversal was wrong for bits 1 and 3 of the 5 bits. Result is driver failure to probe if you have more than 2 daisy-chained devices. Discovered via QEMU based device emulation. Fixes tag is for when this moved from a macro to a function, but it was broken before that. Signed-off-by: Jonathan Cameron Fixes: 065a7c0b1fec ("Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse") --- drivers/staging/iio/adc/ad7280a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index fef0055b8990..20183b2ea127 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b/drivers/staging/iio/adc/ad7280a.c @@ -107,9 +107,9 @@ static unsigned int ad7280a_devaddr(unsigned int addr) { return ((addr & 0x1) << 4) | - ((addr & 0x2) << 3) | + ((addr & 0x2) << 2) | (addr & 0x4) | - ((addr & 0x8) >> 3) | + ((addr & 0x8) >> 2) | ((addr & 0x10) >> 4); }