diff mbox series

[1/4] dt-bindings: iio: accel: bma255: Add interrupt-names

Message ID 20210719112156.27087-2-stephan@gerhold.net (mailing list archive)
State Changes Requested
Headers show
Series iio: accel: bmc150: Add support for INT2 and BMC156 | expand

Commit Message

Stephan Gerhold July 19, 2021, 11:21 a.m. UTC
The binding already allows specifying both interrupt pins, but there
is currently no way to describe a board where (for whatever reason)
only INT2 is connected. Make it possible to use "interrupt-names"
to make it explicit which interrupt pin is meant in the interrupts.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 .../devicetree/bindings/iio/accel/bosch,bma255.yaml      | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Linus Walleij July 19, 2021, 1:57 p.m. UTC | #1
On Mon, Jul 19, 2021 at 1:26 PM Stephan Gerhold <stephan@gerhold.net> wrote:

> The binding already allows specifying both interrupt pins, but there
> is currently no way to describe a board where (for whatever reason)
> only INT2 is connected. Make it possible to use "interrupt-names"
> to make it explicit which interrupt pin is meant in the interrupts.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Jonathan Cameron July 24, 2021, 4 p.m. UTC | #2
On Mon, 19 Jul 2021 13:21:53 +0200
Stephan Gerhold <stephan@gerhold.net> wrote:

> The binding already allows specifying both interrupt pins, but there
> is currently no way to describe a board where (for whatever reason)
> only INT2 is connected. Make it possible to use "interrupt-names"
> to make it explicit which interrupt pin is meant in the interrupts.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>  .../devicetree/bindings/iio/accel/bosch,bma255.yaml      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> index 5b35856b1942..897a1d808ef5 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> @@ -49,6 +49,14 @@ properties:
>        the second (optional) interrupt listed must be the one connected to the
>        INT2 pin (if available). The type should be IRQ_TYPE_EDGE_RISING.

Looks like this comment needs updating to say the ordering is only true if
interrupt-names is not present.

Jonathan


>  
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 2
> +    items:
> +      enum:
> +        - INT1
> +        - INT2
> +
>    mount-matrix:
>      description: an optional 3x3 mounting rotation matrix.
>  
> @@ -73,6 +81,7 @@ examples:
>              vddio-supply = <&vddio>;
>              vdd-supply = <&vdd>;
>              interrupts = <57 IRQ_TYPE_EDGE_RISING>;
> +            interrupt-names = "INT1";
>          };
>      };
>    - |
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
index 5b35856b1942..897a1d808ef5 100644
--- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
@@ -49,6 +49,14 @@  properties:
       the second (optional) interrupt listed must be the one connected to the
       INT2 pin (if available). The type should be IRQ_TYPE_EDGE_RISING.
 
+  interrupt-names:
+    minItems: 1
+    maxItems: 2
+    items:
+      enum:
+        - INT1
+        - INT2
+
   mount-matrix:
     description: an optional 3x3 mounting rotation matrix.
 
@@ -73,6 +81,7 @@  examples:
             vddio-supply = <&vddio>;
             vdd-supply = <&vdd>;
             interrupts = <57 IRQ_TYPE_EDGE_RISING>;
+            interrupt-names = "INT1";
         };
     };
   - |