| Message ID | 20210722062155.32998-2-puranjay12@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: accel: add support for ADXL355 | expand |
On Thu, 22 Jul 2021 11:51:53 +0530 Puranjay Mohan <puranjay12@gmail.com> wrote: > Add ADXL355, a 3-Axis MEMS Accelerometer into trivial-devices.yaml. > > Signed-off-by: Puranjay Mohan <puranjay12@gmail.com> Hi Puranjay, So, a binding should include (as well as we can) all hardware elements, not just those currently supported by the driver. This particular device has two interrupts + a dataready signal which is effectively another interrupt. It also has dual power supplies. That makes it a rather non-trivial device from the point of view of bindings. Hence, please give it a file of it's own and also document the interrupt and supply elements. Jonathan > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 8341e9d23..0097d6e81 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -41,6 +41,8 @@ properties: > - adi,adp5589 > # +/-1C TDM Extended Temp Range I.C > - adi,adt7461 > + # ADXL355:- 3-Axis Low noise MEMS Accelerometer. > + - adi,adxl355 > # +/-1C TDM Extended Temp Range I.C > - adt7461 > # AMS iAQ-Core VOC Sensor
On Fri, Jul 23, 2021 at 9:59 PM Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > > On Thu, 22 Jul 2021 11:51:53 +0530 > Puranjay Mohan <puranjay12@gmail.com> wrote: > > > Add ADXL355, a 3-Axis MEMS Accelerometer into trivial-devices.yaml. > > > > Signed-off-by: Puranjay Mohan <puranjay12@gmail.com> > > Hi Puranjay, > > So, a binding should include (as well as we can) all hardware elements, > not just those currently supported by the driver. > > This particular device has two interrupts + a dataready signal which is > effectively another interrupt. It also has dual power supplies. > > That makes it a rather non-trivial device from the point of view of > bindings. Hence, please give it a file of it's own and also document > the interrupt and supply elements. > > Jonathan > I will add a separate file in the next version. thanks, Puranjay > > --- > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 8341e9d23..0097d6e81 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -41,6 +41,8 @@ properties: > > - adi,adp5589 > > # +/-1C TDM Extended Temp Range I.C > > - adi,adt7461 > > + # ADXL355:- 3-Axis Low noise MEMS Accelerometer. > > + - adi,adxl355 > > # +/-1C TDM Extended Temp Range I.C > > - adt7461 > > # AMS iAQ-Core VOC Sensor >
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 8341e9d23..0097d6e81 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -41,6 +41,8 @@ properties: - adi,adp5589 # +/-1C TDM Extended Temp Range I.C - adi,adt7461 + # ADXL355:- 3-Axis Low noise MEMS Accelerometer. + - adi,adxl355 # +/-1C TDM Extended Temp Range I.C - adt7461 # AMS iAQ-Core VOC Sensor
Add ADXL355, a 3-Axis MEMS Accelerometer into trivial-devices.yaml. Signed-off-by: Puranjay Mohan <puranjay12@gmail.com> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)