diff mbox series

iio: accel: fxls8962af: return IRQ_HANDLED when fifo is flushed

Message ID 20210817124336.1672169-1-sean@geanix.com (mailing list archive)
State Accepted
Headers show
Series iio: accel: fxls8962af: return IRQ_HANDLED when fifo is flushed | expand

Commit Message

Sean Nyekjaer Aug. 17, 2021, 12:43 p.m. UTC
fxls8962af_fifo_flush() will return the samples flushed.
So return IRQ_NONE only if an error is returned.

Fixes: 79e3a5bdd9ef ("iio: accel: fxls8962af: add hw buffered sampling")
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 drivers/iio/accel/fxls8962af-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron Aug. 29, 2021, 3:59 p.m. UTC | #1
On Tue, 17 Aug 2021 14:43:36 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> fxls8962af_fifo_flush() will return the samples flushed.
> So return IRQ_NONE only if an error is returned.
> 
> Fixes: 79e3a5bdd9ef ("iio: accel: fxls8962af: add hw buffered sampling")
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/accel/fxls8962af-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 078d87865fde..6b36eb362d07 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -738,7 +738,7 @@ static irqreturn_t fxls8962af_interrupt(int irq, void *p)
>  
>  	if (reg & FXLS8962AF_INT_STATUS_SRC_BUF) {
>  		ret = fxls8962af_fifo_flush(indio_dev);
> -		if (ret)
> +		if (ret < 0)
>  			return IRQ_NONE;
>  
>  		return IRQ_HANDLED;
diff mbox series

Patch

diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
index 078d87865fde..6b36eb362d07 100644
--- a/drivers/iio/accel/fxls8962af-core.c
+++ b/drivers/iio/accel/fxls8962af-core.c
@@ -738,7 +738,7 @@  static irqreturn_t fxls8962af_interrupt(int irq, void *p)
 
 	if (reg & FXLS8962AF_INT_STATUS_SRC_BUF) {
 		ret = fxls8962af_fifo_flush(indio_dev);
-		if (ret)
+		if (ret < 0)
 			return IRQ_NONE;
 
 		return IRQ_HANDLED;