| Message ID | 20210928014156.1491-2-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() | expand |
On Tue, 28 Sep 2021 09:41:53 +0800 Cai Huoqing <caihuoqing@baidu.com> wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> To cut down on repeat sends I'm going to cherry pick individual patches out of this series. Please send updates for the those patches I don't pick up where I've requested changes. Applied this patch to the togreg branch of iio.git and pushed out as testing for 0-day to test it. Thanks, Jonathan > --- > v1->v2: Remove the separate line of PTR_ERR(). > > drivers/iio/light/cm36651.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c > index fd83a19929bc..c7cc4b0fe8b2 100644 > --- a/drivers/iio/light/cm36651.c > +++ b/drivers/iio/light/cm36651.c > @@ -632,10 +632,9 @@ static int cm36651_probe(struct i2c_client *client, > cm36651 = iio_priv(indio_dev); > > cm36651->vled_reg = devm_regulator_get(&client->dev, "vled"); > - if (IS_ERR(cm36651->vled_reg)) { > - dev_err(&client->dev, "get regulator vled failed\n"); > - return PTR_ERR(cm36651->vled_reg); > - } > + if (IS_ERR(cm36651->vled_reg)) > + return dev_err_probe(&client->dev, PTR_ERR(cm36651->vled_reg), > + "get regulator vled failed\n"); > > ret = regulator_enable(cm36651->vled_reg); > if (ret) {
diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c index fd83a19929bc..c7cc4b0fe8b2 100644 --- a/drivers/iio/light/cm36651.c +++ b/drivers/iio/light/cm36651.c @@ -632,10 +632,9 @@ static int cm36651_probe(struct i2c_client *client, cm36651 = iio_priv(indio_dev); cm36651->vled_reg = devm_regulator_get(&client->dev, "vled"); - if (IS_ERR(cm36651->vled_reg)) { - dev_err(&client->dev, "get regulator vled failed\n"); - return PTR_ERR(cm36651->vled_reg); - } + if (IS_ERR(cm36651->vled_reg)) + return dev_err_probe(&client->dev, PTR_ERR(cm36651->vled_reg), + "get regulator vled failed\n"); ret = regulator_enable(cm36651->vled_reg); if (ret) {
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- v1->v2: Remove the separate line of PTR_ERR(). drivers/iio/light/cm36651.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)