| Message ID | 20210928014403.1563-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] iio: health: afe4403: Make use of the helper function dev_err_probe() | expand |
On Tue, 28 Sep 2021 09:44:01 +0800 Cai Huoqing <caihuoqing@baidu.com> wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Series applied and pushed out as testing for 0-day to see if it can find anything we missed. Thanks, Jonathan > --- > v1->v2: Remove the separate line of PTR_ERR(). > > drivers/iio/health/afe4403.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c > index d4921385aaf7..3a8cfb669b25 100644 > --- a/drivers/iio/health/afe4403.c > +++ b/drivers/iio/health/afe4403.c > @@ -487,10 +487,10 @@ static int afe4403_probe(struct spi_device *spi) > } > > afe->regulator = devm_regulator_get(afe->dev, "tx_sup"); > - if (IS_ERR(afe->regulator)) { > - dev_err(afe->dev, "Unable to get regulator\n"); > - return PTR_ERR(afe->regulator); > - } > + if (IS_ERR(afe->regulator)) > + return dev_err_probe(afe->dev, PTR_ERR(afe->regulator), > + "Unable to get regulator\n"); > + > ret = regulator_enable(afe->regulator); > if (ret) { > dev_err(afe->dev, "Unable to enable regulator\n");
diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c index d4921385aaf7..3a8cfb669b25 100644 --- a/drivers/iio/health/afe4403.c +++ b/drivers/iio/health/afe4403.c @@ -487,10 +487,10 @@ static int afe4403_probe(struct spi_device *spi) } afe->regulator = devm_regulator_get(afe->dev, "tx_sup"); - if (IS_ERR(afe->regulator)) { - dev_err(afe->dev, "Unable to get regulator\n"); - return PTR_ERR(afe->regulator); - } + if (IS_ERR(afe->regulator)) + return dev_err_probe(afe->dev, PTR_ERR(afe->regulator), + "Unable to get regulator\n"); + ret = regulator_enable(afe->regulator); if (ret) { dev_err(afe->dev, "Unable to enable regulator\n");
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- v1->v2: Remove the separate line of PTR_ERR(). drivers/iio/health/afe4403.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)