diff mbox series

mux: fix kernel doc prototype

Message ID 20211019064521.18113-1-vincent.whitchurch@axis.com (mailing list archive)
State Accepted
Headers show
Series mux: fix kernel doc prototype | expand

Commit Message

Vincent Whitchurch Oct. 19, 2021, 6:45 a.m. UTC
Fix this warning from scripts/kernel-doc:

 drivers/mux/core.c:391: warning: expecting prototype for
 mux_control_try_select(). Prototype was for
 mux_control_try_select_delay() instead

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
---
 drivers/mux/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Rosin Oct. 19, 2021, 7:17 a.m. UTC | #1
On 2021-10-19 08:45, Vincent Whitchurch wrote:
> Fix this warning from scripts/kernel-doc:
> 
>  drivers/mux/core.c:391: warning: expecting prototype for
>  mux_control_try_select(). Prototype was for
>  mux_control_try_select_delay() instead
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

Obviously. Or, just squash it if that's still an option?

In case it's easier to just pile it on top:

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter
Jonathan Cameron Oct. 20, 2021, 8:27 p.m. UTC | #2
On Tue, 19 Oct 2021 09:17:07 +0200
Peter Rosin <peda@axentia.se> wrote:

> On 2021-10-19 08:45, Vincent Whitchurch wrote:
> > Fix this warning from scripts/kernel-doc:
> > 
> >  drivers/mux/core.c:391: warning: expecting prototype for
> >  mux_control_try_select(). Prototype was for
> >  mux_control_try_select_delay() instead
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>  
> 
> Obviously. Or, just squash it if that's still an option?
Folded into original commit.

Thanks,

Jonathan

> 
> In case it's easier to just pile it on top:
> 
> Acked-by: Peter Rosin <peda@axentia.se>
> 
> Cheers,
> Peter
Peter Rosin Oct. 20, 2021, 8:49 p.m. UTC | #3
On 2021-10-20 22:27, Jonathan Cameron wrote:
> On Tue, 19 Oct 2021 09:17:07 +0200
> Peter Rosin <peda@axentia.se> wrote:
> 
>> On 2021-10-19 08:45, Vincent Whitchurch wrote:
>>> Fix this warning from scripts/kernel-doc:
>>>
>>>  drivers/mux/core.c:391: warning: expecting prototype for
>>>  mux_control_try_select(). Prototype was for
>>>  mux_control_try_select_delay() instead
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>  
>>
>> Obviously. Or, just squash it if that's still an option?
> Folded into original commit.
> 
> Thanks,
> 
> Jonathan

And I would like to say thanks for a nice series from Vincent and
to you Jonathan for taking care of the mechanics. Much appreciated!

Cheers,
Peter
diff mbox series

Patch

diff --git a/drivers/mux/core.c b/drivers/mux/core.c
index dee6945e92f7..22f4709768d1 100644
--- a/drivers/mux/core.c
+++ b/drivers/mux/core.c
@@ -371,7 +371,7 @@  int mux_control_select_delay(struct mux_control *mux, unsigned int state,
 EXPORT_SYMBOL_GPL(mux_control_select_delay);
 
 /**
- * mux_control_try_select() - Try to select the given multiplexer state.
+ * mux_control_try_select_delay() - Try to select the given multiplexer state.
  * @mux: The mux-control to request a change of state from.
  * @state: The new requested state.
  * @delay_us: The time to delay (in microseconds) if the mux state is changed.