| Message ID | 20211028101840.24632-3-andrea.merello@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for Bosch BNO055 IMU | expand |
On Thu, Oct 28, 2021 at 1:18 PM Andrea Merello <andrea.merello@gmail.com> wrote: > > This patch introduces ABI documentation for new iio modifiers used for > reporting "linear acceleration" measures. Because of ordering and absence of Fixes tag I haven't clearly got if this is an existing set of attributes or that that will be added by the series. If the former, use a Fixes tag and place it first in the series. If the latter, move it after the actual addition of the attributes in the code.
On Thu, 28 Oct 2021 12:18:32 +0200 Andrea Merello <andrea.merello@gmail.com> wrote: > This patch introduces ABI documentation for new iio modifiers used for > reporting "linear acceleration" measures. > > Signed-off-by: Andrea Merello <andrea.merello@iit.it> > --- > Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index 6ad47a67521c..5147a00bf24a 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -1957,3 +1957,11 @@ Description: > Specify the percent for light sensor relative to the channel > absolute value that a data field should change before an event > is generated. Units are a percentage of the prior reading. > + > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_x_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_y_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_z_raw > +KernelVersion: 5.15 > +Contact: linux-iio@vger.kernel.org > +Description: > + Raw (unscaled) linear acceleration readings. Probably need more information that this. What element is being 'removed' from a normal acceleration measurement? What are units after application of offset and scale? Can cross refer to the in_accel_x_raw for that info if you like. Also, but them immediately after the block with the in_accel_x_raw etc The organization fo that file needs a rethink but let us try to avoid making it worse in the meeantime! Jonathan
Il giorno gio 28 ott 2021 alle ore 12:32 Andy Shevchenko <andy.shevchenko@gmail.com> ha scritto: > > On Thu, Oct 28, 2021 at 1:18 PM Andrea Merello <andrea.merello@gmail.com> wrote: > > > > This patch introduces ABI documentation for new iio modifiers used for > > reporting "linear acceleration" measures. > > Because of ordering and absence of Fixes tag I haven't clearly got if > this is an existing set of attributes or that that will be added by > the series. If the former, use a Fixes tag and place it first in the > series. If the latter, move it after the actual addition of the > attributes in the code. The latter. Will move in V3. Thanks > -- > With Best Regards, > Andy Shevchenko
Il giorno gio 28 ott 2021 alle ore 12:35 Jonathan Cameron <jic23@kernel.org> ha scritto: > > On Thu, 28 Oct 2021 12:18:32 +0200 > Andrea Merello <andrea.merello@gmail.com> wrote: > > > This patch introduces ABI documentation for new iio modifiers used for > > reporting "linear acceleration" measures. > > > > Signed-off-by: Andrea Merello <andrea.merello@iit.it> > > --- > > Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > > index 6ad47a67521c..5147a00bf24a 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-iio > > +++ b/Documentation/ABI/testing/sysfs-bus-iio > > @@ -1957,3 +1957,11 @@ Description: > > Specify the percent for light sensor relative to the channel > > absolute value that a data field should change before an event > > is generated. Units are a percentage of the prior reading. > > + > > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_x_raw > > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_y_raw > > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_z_raw > > +KernelVersion: 5.15 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Raw (unscaled) linear acceleration readings. > > Probably need more information that this. What element is being 'removed' from > a normal acceleration measurement? What are units after application of offset and > scale? Can cross refer to the in_accel_x_raw for that info if you like. OK. So, may I just state something like "As per in_accel_X_raw attributes, but minus the gravity acceleration" ? > Also, but them immediately after the block with the in_accel_x_raw etc OK > The organization fo that file needs a rethink but let us try to avoid making > it worse in the meeantime! > > Jonathan > >
On Tue, 9 Nov 2021 09:00:09 +0100 Andrea Merello <andrea.merello@gmail.com> wrote: > Il giorno gio 28 ott 2021 alle ore 12:35 Jonathan Cameron > <jic23@kernel.org> ha scritto: > > > > On Thu, 28 Oct 2021 12:18:32 +0200 > > Andrea Merello <andrea.merello@gmail.com> wrote: > > > > > This patch introduces ABI documentation for new iio modifiers used for > > > reporting "linear acceleration" measures. > > > > > > Signed-off-by: Andrea Merello <andrea.merello@iit.it> > > > --- > > > Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > > > index 6ad47a67521c..5147a00bf24a 100644 > > > --- a/Documentation/ABI/testing/sysfs-bus-iio > > > +++ b/Documentation/ABI/testing/sysfs-bus-iio > > > @@ -1957,3 +1957,11 @@ Description: > > > Specify the percent for light sensor relative to the channel > > > absolute value that a data field should change before an event > > > is generated. Units are a percentage of the prior reading. > > > + > > > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_x_raw > > > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_y_raw > > > +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_z_raw > > > +KernelVersion: 5.15 > > > +Contact: linux-iio@vger.kernel.org > > > +Description: > > > + Raw (unscaled) linear acceleration readings. > > > > Probably need more information that this. What element is being 'removed' from > > a normal acceleration measurement? What are units after application of offset and > > scale? Can cross refer to the in_accel_x_raw for that info if you like. > > OK. So, may I just state something like "As per in_accel_X_raw > attributes, but minus the gravity acceleration" ? Yup, something along those lines. Wow, I had a lot of typos in my email. :) Jonathan > > > Also, but them immediately after the block with the in_accel_x_raw etc > > OK > > > The organization fo that file needs a rethink but let us try to avoid making > > it worse in the meeantime! > > > > Jonathan > > > >
diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio index 6ad47a67521c..5147a00bf24a 100644 --- a/Documentation/ABI/testing/sysfs-bus-iio +++ b/Documentation/ABI/testing/sysfs-bus-iio @@ -1957,3 +1957,11 @@ Description: Specify the percent for light sensor relative to the channel absolute value that a data field should change before an event is generated. Units are a percentage of the prior reading. + +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_x_raw +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_y_raw +What: /sys/bus/iio/devices/iio:deviceX/in_accel_linear_z_raw +KernelVersion: 5.15 +Contact: linux-iio@vger.kernel.org +Description: + Raw (unscaled) linear acceleration readings.
This patch introduces ABI documentation for new iio modifiers used for reporting "linear acceleration" measures. Signed-off-by: Andrea Merello <andrea.merello@iit.it> --- Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++ 1 file changed, 8 insertions(+)