| Message ID | 20211111083954.6286-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config | expand |
Hi Lukas, On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP > ADC") adds the config IMX8QXP_ADC for this new driver, which depends on > the non-existing config ARCH_MXC_ARM64. > > Hence, ./scripts/checkkconfigsymbols.py warns: > > ARCH_MXC_ARM64 > Referencing files: drivers/iio/adc/Kconfig > > Probably, the existing config ARCH_MXC is intended to be referred here. > So, repair the dependency to refer to that config. > > Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> This looks good. The incorrect ARCH_MXC_ARM64 symbol probably came when porting the driver from the NXP downstream kernel: Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Thu, 11 Nov 2021 07:31:25 -0300 Fabio Estevam <festevam@gmail.com> wrote: > Hi Lukas, > > On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > > > Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP > > ADC") adds the config IMX8QXP_ADC for this new driver, which depends on > > the non-existing config ARCH_MXC_ARM64. > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > ARCH_MXC_ARM64 > > Referencing files: drivers/iio/adc/Kconfig > > > > Probably, the existing config ARCH_MXC is intended to be referred here. > > So, repair the dependency to refer to that config. > > > > Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > This looks good. > > The incorrect ARCH_MXC_ARM64 symbol probably came when porting the > driver from the NXP downstream kernel: > > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to the fixes-togreg branch of iio.git Thanks, Jonathan
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 8bf5b62a73f4..3363af15a43f 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -532,7 +532,7 @@ config IMX7D_ADC config IMX8QXP_ADC tristate "NXP IMX8QXP ADC driver" - depends on ARCH_MXC_ARM64 || COMPILE_TEST + depends on ARCH_MXC || COMPILE_TEST depends on HAS_IOMEM help Say yes here to build support for IMX8QXP ADC.
Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") adds the config IMX8QXP_ADC for this new driver, which depends on the non-existing config ARCH_MXC_ARM64. Hence, ./scripts/checkkconfigsymbols.py warns: ARCH_MXC_ARM64 Referencing files: drivers/iio/adc/Kconfig Probably, the existing config ARCH_MXC is intended to be referred here. So, repair the dependency to refer to that config. Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- drivers/iio/adc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)