| Message ID | 20211122133639.132972-2-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/2] iio:amplifiers:ad7293: add support for AD7293 | expand |
On Mon, 22 Nov 2021 15:36:39 +0200 Antoniu Miclaus <antoniu.miclaus@analog.com> wrote: > Add device tree bindings for the AD7293 Power Amplifier. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> One comment inline but very minor so if Rob + anyone else is happy with this we can leave that or I can tidy it up whilst applying. Thanks, Jonathan > --- > changes in v4: > - set `avdd-supply: true` > - set `maxItems` for reset-gpios > .../bindings/iio/dac/adi,ad7293.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml > new file mode 100644 > index 000000000000..7951ffe8805b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/adi,ad7293.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AD7293 12-Bit Power Amplifier Current Controller with ADC, > + DACs, Temperature and Current Sensors > + > +maintainers: > + - Antoniu Miclaus <antoniu.miclaus@analog.com> > + > +description: | > + Power Amplifier drain current controller containing functionality > + for general-purpose monitoring and control of current, voltage, > + and temperature, integrated into a single chip solution with an > + SPI-compatible interface. > + > + https://www.analog.com/en/products/ad7293.html > + > +properties: > + compatible: > + enum: > + - adi,ad7293 > + > + avdd-supply: true > + > + vdrive-supply: > + description: > + VDRIVE voltage regulator. Could do the same with this one as with the avdd. Telling us something called vdrive-supply is the VDRIVE supply doesn't add much. However, doesn't do that much harm either so I'm not that fussed. Jonathan > + > + reset-gpios: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 1000000 > + > +required: > + - compatible > + - reg > + - avdd-supply > + - vdrive-supply > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + ad7293@0 { > + compatible = "adi,ad7293"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + avdd-supply = <&avdd>; > + vdrive-supply = <&vdrive>; > + reset-gpios = <&gpio 10 0>; > + }; > + }; > +...
On Mon, 22 Nov 2021 15:36:39 +0200, Antoniu Miclaus wrote: > Add device tree bindings for the AD7293 Power Amplifier. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > changes in v4: > - set `avdd-supply: true` > - set `maxItems` for reset-gpios > .../bindings/iio/dac/adi,ad7293.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml new file mode 100644 index 000000000000..7951ffe8805b --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/dac/adi,ad7293.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AD7293 12-Bit Power Amplifier Current Controller with ADC, + DACs, Temperature and Current Sensors + +maintainers: + - Antoniu Miclaus <antoniu.miclaus@analog.com> + +description: | + Power Amplifier drain current controller containing functionality + for general-purpose monitoring and control of current, voltage, + and temperature, integrated into a single chip solution with an + SPI-compatible interface. + + https://www.analog.com/en/products/ad7293.html + +properties: + compatible: + enum: + - adi,ad7293 + + avdd-supply: true + + vdrive-supply: + description: + VDRIVE voltage regulator. + + reset-gpios: + maxItems: 1 + + reg: + maxItems: 1 + + spi-max-frequency: + maximum: 1000000 + +required: + - compatible + - reg + - avdd-supply + - vdrive-supply + +additionalProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + ad7293@0 { + compatible = "adi,ad7293"; + reg = <0>; + spi-max-frequency = <1000000>; + avdd-supply = <&avdd>; + vdrive-supply = <&vdrive>; + reset-gpios = <&gpio 10 0>; + }; + }; +...
Add device tree bindings for the AD7293 Power Amplifier. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- changes in v4: - set `avdd-supply: true` - set `maxItems` for reset-gpios .../bindings/iio/dac/adi,ad7293.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad7293.yaml