| Message ID | 20211123115336.65827-2-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v5,1/3] iio: frequency: admv1013: add support for ADMV1013 | expand |
On Tue, 23 Nov 2021 13:53:35 +0200 Antoniu Miclaus <antoniu.miclaus@analog.com> wrote: > Add device tree bindings for the ADMV1013 Upconverter. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> Hi Antoniu One comment inline + as noted in the ABI, I think the freq_mode belongs in here as something like adi,input-mode or something like that. Thanks, Jonathan > --- > - remove powerdown properties from the dt bindings > - update quad-se-mode property using strings enum > .../bindings/iio/frequency/adi,admv1013.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > new file mode 100644 > index 000000000000..adbff58cbbf4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/frequency/adi,admv1013.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADMV1013 Microwave Upconverter > + > +maintainers: > + - Antoniu Miclaus <antoniu.miclaus@analog.com> > + > +description: | > + Wideband, microwave upconverter optimized for point to point microwave > + radio designs operating in the 24 GHz to 44 GHz frequency range. > + > + https://www.analog.com/en/products/admv1013.html > + > +properties: > + compatible: > + enum: > + - adi,admv1013 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 1000000 > + > + clocks: > + description: > + Definition of the external clock. > + minItems: 1 > + > + clock-names: > + items: > + - const: lo_in > + > + clock-output-names: > + maxItems: 1 Does it provide a clock? Whilst there is a high frequency output I'm not sure anyone would term it a clock or that it would be helfpul to manage it like that... > + > + vcm-supply: > + description: > + Analog voltage regulator. > + > + adi,detector-enable: > + description: > + Enable the Envelope Detector available at output pins VENV_P and > + VENV_N. Disable to reduce power consumption. > + type: boolean > + > + adi,quad-se-mode: > + description: > + Switch the LO path from differential to single-ended operation. > + se-neg - Single-Ended Mode, Negative Side Disabled. > + se-pos - Single-Ended Mode, Positive Side Disabled. > + diff - Differential Mode. > + enum: [se-neg, se-pos, diff] > + > + '#clock-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - vcm-supply > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + admv1013@0{ > + compatible = "adi,admv1013"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + clocks = <&admv1013_lo>; > + clock-names = "lo_in"; > + vcm-supply = <&vcm>; > + adi,quad-se-mode = "diff"; > + adi,detector-enable; > + }; > + }; > +...
diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml new file mode 100644 index 000000000000..adbff58cbbf4 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/frequency/adi,admv1013.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ADMV1013 Microwave Upconverter + +maintainers: + - Antoniu Miclaus <antoniu.miclaus@analog.com> + +description: | + Wideband, microwave upconverter optimized for point to point microwave + radio designs operating in the 24 GHz to 44 GHz frequency range. + + https://www.analog.com/en/products/admv1013.html + +properties: + compatible: + enum: + - adi,admv1013 + + reg: + maxItems: 1 + + spi-max-frequency: + maximum: 1000000 + + clocks: + description: + Definition of the external clock. + minItems: 1 + + clock-names: + items: + - const: lo_in + + clock-output-names: + maxItems: 1 + + vcm-supply: + description: + Analog voltage regulator. + + adi,detector-enable: + description: + Enable the Envelope Detector available at output pins VENV_P and + VENV_N. Disable to reduce power consumption. + type: boolean + + adi,quad-se-mode: + description: + Switch the LO path from differential to single-ended operation. + se-neg - Single-Ended Mode, Negative Side Disabled. + se-pos - Single-Ended Mode, Positive Side Disabled. + diff - Differential Mode. + enum: [se-neg, se-pos, diff] + + '#clock-cells': + const: 0 + +required: + - compatible + - reg + - clocks + - clock-names + - vcm-supply + +additionalProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + admv1013@0{ + compatible = "adi,admv1013"; + reg = <0>; + spi-max-frequency = <1000000>; + clocks = <&admv1013_lo>; + clock-names = "lo_in"; + vcm-supply = <&vcm>; + adi,quad-se-mode = "diff"; + adi,detector-enable; + }; + }; +...
Add device tree bindings for the ADMV1013 Upconverter. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- - remove powerdown properties from the dt bindings - update quad-se-mode property using strings enum .../bindings/iio/frequency/adi,admv1013.yaml | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml