| Message ID | 20211204171237.2769210-13-jic23@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | IIO: More of to generic fw conversions. | expand |
On Sat, Dec 4, 2021 at 7:08 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > We could probably drop a lot more of these, but for now this removes > unnecessary restrictions on stand alone ADC devices. Ah, I was expecting to see this on per driver conversion change. Is this simply dependencies which are not covered anyhow by the previous 11 patches in the series?
On Sun, 5 Dec 2021 17:15:41 +0200 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sat, Dec 4, 2021 at 7:08 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > We could probably drop a lot more of these, but for now this removes > > unnecessary restrictions on stand alone ADC devices. > > Ah, I was expecting to see this on per driver conversion change. > Is this simply dependencies which are not covered anyhow by the > previous 11 patches in the series? > Yup. None of these dependencies should have been there even without this series. The ads8344 and ads8688 go all the way back to initial driver patches and I can't see why they were ever needed. max5821 looks similar. I've added a note to the patch description to make it clearer what is going on in this patch. Jonathan
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 9b0b99bc826c..c7de4632f24a 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -1146,7 +1146,7 @@ config TI_ADS7950 config TI_ADS8344 tristate "Texas Instruments ADS8344" - depends on SPI && OF + depends on SPI help If you say yes here you get support for Texas Instruments ADS8344 ADC chips @@ -1156,7 +1156,7 @@ config TI_ADS8344 config TI_ADS8688 tristate "Texas Instruments ADS8688" - depends on SPI && OF + depends on SPI help If you say yes here you get support for Texas Instruments ADS8684 and and ADS8688 ADC chips diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index 75e1f2b48638..ba6649a2d040 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -329,7 +329,6 @@ config MAX517 config MAX5821 tristate "Maxim MAX5821 DAC driver" depends on I2C - depends on OF help Say yes here to build support for Maxim MAX5821 10 bits DAC.