| Message ID | 20211217095401.583821-1-eugen.hristev@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory | expand |
On Fri, 17 Dec 2021 11:54:01 +0200, Eugen Hristev wrote: > The atmel,trigger-edge-type was never imposed by the driver. > Make things right and remove this property from the mandatory list. > This will not break existing nodes because according to the binding they > should have this property. > However, the driver does not impose it and it works without it, the property > selects the trigger type, and without it, the driver will have no trigger > available, which is the case on some boards which do not have access > to the trigger pin. > This will avoid generating this warning for example: > > */arch/arm/boot/dts/at91-sama7g5ek.dt.yaml: adc@e1000000: 'atmel,trigger-edge-type' is a required property > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 21 Dec 2021 14:08:58 -0400 Rob Herring <robh@kernel.org> wrote: > On Fri, 17 Dec 2021 11:54:01 +0200, Eugen Hristev wrote: > > The atmel,trigger-edge-type was never imposed by the driver. > > Make things right and remove this property from the mandatory list. > > This will not break existing nodes because according to the binding they > > should have this property. > > However, the driver does not impose it and it works without it, the property > > selects the trigger type, and without it, the driver will have no trigger > > available, which is the case on some boards which do not have access > > to the trigger pin. > > This will avoid generating this warning for example: > > > > */arch/arm/boot/dts/at91-sama7g5ek.dt.yaml: adc@e1000000: 'atmel,trigger-edge-type' is a required property > > > > Acked-by: Rob Herring <robh@kernel.org> oops. I lost this one until doing a cleanup of patchwork. Anyhow, now applied to the togreg branch of iio.git and pushed out as testing for all the normal reasons. Sorry for the delay! Jonathan
diff --git a/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml b/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml index efed361215b4b..482d80dd43b5f 100644 --- a/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml @@ -72,7 +72,6 @@ required: - atmel,min-sample-rate-hz - atmel,max-sample-rate-hz - atmel,startup-time-ms - - atmel,trigger-edge-type examples: - |
The atmel,trigger-edge-type was never imposed by the driver. Make things right and remove this property from the mandatory list. This will not break existing nodes because according to the binding they should have this property. However, the driver does not impose it and it works without it, the property selects the trigger type, and without it, the driver will have no trigger available, which is the case on some boards which do not have access to the trigger pin. This will avoid generating this warning for example: */arch/arm/boot/dts/at91-sama7g5ek.dt.yaml: adc@e1000000: 'atmel,trigger-edge-type' is a required property From schema: */Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml | 1 - 1 file changed, 1 deletion(-)