| Message ID | 20220315173042.1325858-3-gwendal@chromium.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add settings for precharge and internal resistor | expand |
Quoting Gwendal Grignou (2022-03-15 10:30:37) > Allow configure the resistance used during precharge. > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > --- > .../bindings/iio/proximity/semtech,sx9324.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > index b8a6ee16854ff..cd8ed50f2882a 100644 > --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > @@ -126,6 +126,14 @@ properties: > UINT_MAX (4294967295) represents infinite. Other values > represent 1-1/N. > > + semtech,input-precharge-resistor: It is clearer when the units are in the name of the property. semtech,input-precharge-resistor-kohms
On Tue, 15 Mar 2022 13:05:38 -0700 Stephen Boyd <swboyd@chromium.org> wrote: > Quoting Gwendal Grignou (2022-03-15 10:30:37) > > Allow configure the resistance used during precharge. > > > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > > --- > > .../bindings/iio/proximity/semtech,sx9324.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > > index b8a6ee16854ff..cd8ed50f2882a 100644 > > --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > > +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml > > @@ -126,6 +126,14 @@ properties: > > UINT_MAX (4294967295) represents infinite. Other values > > represent 1-1/N. > > > > + semtech,input-precharge-resistor: > > It is clearer when the units are in the name of the property. > > semtech,input-precharge-resistor-kohms Added bonus is that you won't need the ref if the units chosen match one of the ones in https://github.com/robherring/dt-schema/blob/master/schemas/property-units.yaml Note kohms isn't there so unless we have an issue representing this in ohms, please use that instead. Jonathan
diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml index b8a6ee16854ff..cd8ed50f2882a 100644 --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml @@ -126,6 +126,14 @@ properties: UINT_MAX (4294967295) represents infinite. Other values represent 1-1/N. + semtech,input-precharge-resistor: + $ref: /schemas/types.yaml#/definitions/uint32 + default: 4 + description: + Pre-charge input resistance in kOhm. + minimum: 0 + maximum: 30 + required: - compatible - reg @@ -157,5 +165,6 @@ examples: semtech,ph01-proxraw-strength = <2>; semtech,ph23-proxraw-strength = <2>; semtech,avg-pos-strength = <64>; + semtech,input-precharge-resistor = <2>; }; };
Allow configure the resistance used during precharge. Signed-off-by: Gwendal Grignou <gwendal@chromium.org> --- .../bindings/iio/proximity/semtech,sx9324.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)