diff mbox series

[v2] iio: dac: ltc2688: fix voltage scale read

Message ID 20220412124916.61-1-nuno.sa@analog.com (mailing list archive)
State Accepted
Headers show
Series [v2] iio: dac: ltc2688: fix voltage scale read | expand

Commit Message

Nuno Sá April 12, 2022, 12:49 p.m. UTC
Properly set *val2 (and not overwrite *val) to correctly return
IIO_VAL_FRACTIONAL_LOG2.

Fixes: 832cb9eeb9312 ("iio: dac: add support for ltc2688")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
v2:
 * Fixed repeated "not" in commit description and tweaked patch subject
to match the preferred format.

 drivers/iio/dac/ltc2688.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron April 16, 2022, 2:01 p.m. UTC | #1
On Tue, 12 Apr 2022 14:49:16 +0200
Nuno Sá <nuno.sa@analog.com> wrote:

> Properly set *val2 (and not overwrite *val) to correctly return
> IIO_VAL_FRACTIONAL_LOG2.
> 
> Fixes: 832cb9eeb9312 ("iio: dac: add support for ltc2688")
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Dropped v1 and applied this instead.  

If you detect an issue with a patch you have sent yourself, it is helpful
to reply to that patch to make it clear there will be a v2.
I don't always catch up with all my email in one sitting so can end up
pushing the wrong versions out....

Thanks,

Jonathan

> ---
> v2:
>  * Fixed repeated "not" in commit description and tweaked patch subject
> to match the preferred format.
> 
>  drivers/iio/dac/ltc2688.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ltc2688.c b/drivers/iio/dac/ltc2688.c
> index d249fa28202c..937b0d25a11c 100644
> --- a/drivers/iio/dac/ltc2688.c
> +++ b/drivers/iio/dac/ltc2688.c
> @@ -298,7 +298,7 @@ static int ltc2688_read_raw(struct iio_dev *indio_dev,
>  		if (ret)
>  			return ret;
>  
> -		*val = 16;
> +		*val2 = 16;
>  		return IIO_VAL_FRACTIONAL_LOG2;
>  	case IIO_CHAN_INFO_CALIBBIAS:
>  		ret = regmap_read(st->regmap,
diff mbox series

Patch

diff --git a/drivers/iio/dac/ltc2688.c b/drivers/iio/dac/ltc2688.c
index d249fa28202c..937b0d25a11c 100644
--- a/drivers/iio/dac/ltc2688.c
+++ b/drivers/iio/dac/ltc2688.c
@@ -298,7 +298,7 @@  static int ltc2688_read_raw(struct iio_dev *indio_dev,
 		if (ret)
 			return ret;
 
-		*val = 16;
+		*val2 = 16;
 		return IIO_VAL_FRACTIONAL_LOG2;
 	case IIO_CHAN_INFO_CALIBBIAS:
 		ret = regmap_read(st->regmap,