diff mbox series

[3/8] iio:chemical:atlas: Improve error reporting for problems during .remove()

Message ID 20220515155929.338656-4-u.kleine-koenig@pengutronix.de (mailing list archive)
State Accepted
Headers show
Series iio: Improve error reporting for problems during .remove for various i2c drivers | expand

Commit Message

Uwe Kleine-König May 15, 2022, 3:59 p.m. UTC
Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are

So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/iio/chemical/atlas-sensor.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
index 56dea9734c8d..8378c00fa2ff 100644
--- a/drivers/iio/chemical/atlas-sensor.c
+++ b/drivers/iio/chemical/atlas-sensor.c
@@ -726,6 +726,7 @@  static int atlas_remove(struct i2c_client *client)
 	struct iio_dev *indio_dev = i2c_get_clientdata(client);
 	struct atlas_data *data = iio_priv(indio_dev);
+	int ret;
@@ -734,7 +735,12 @@  static int atlas_remove(struct i2c_client *client)
-	return atlas_set_powermode(data, 0);
+	ret = atlas_set_powermode(data, 0);
+	if (ret)
+		dev_err(&client->dev, "Failed to power down device (%pe)\n",
+			ERR_PTR(ret));
+	return 0;
 static int atlas_runtime_suspend(struct device *dev)