diff mbox series

[06/34] iio: adc: ingenic-adc: explicitly add proper header files

Message ID 20220610084545.547700-7-nuno.sa@analog.com (mailing list archive)
State Accepted
Headers show
Series make iio inkern interface firmware agnostic | expand

Commit Message

Nuno Sá June 10, 2022, 8:45 a.m. UTC
Do not trust the fact that iio.h includes of.h which in turn includes
all the headers we are relying on.

The ultimate goal is to actually drop of.h from iio.h.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/iio/adc/ingenic-adc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andy Shevchenko June 10, 2022, 2:45 p.m. UTC | #1
On Fri, Jun 10, 2022 at 10:46 AM Nuno Sá <nuno.sa@analog.com> wrote:
>
> Do not trust the fact that iio.h includes of.h which in turn includes
> all the headers we are relying on.
>
> The ultimate goal is to actually drop of.h from iio.h.

...

>  #include <linux/mod_devicetable.h>
>  #include <linux/mutex.h>
>  #include <linux/platform_device.h>
> +#include <linux/property.h>
> +#include <linux/of.h>

Ordering (from the context I don't see it's messed up already)
Nuno Sá June 10, 2022, 7:49 p.m. UTC | #2
On Fri, 2022-06-10 at 16:45 +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 10:46 AM Nuno Sá <nuno.sa@analog.com> wrote:
> > 
> > Do not trust the fact that iio.h includes of.h which in turn
> > includes
> > all the headers we are relying on.
> > 
> > The ultimate goal is to actually drop of.h from iio.h.
> 
> ...
> 
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/mutex.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/property.h>
> > +#include <linux/of.h>
> 
> Ordering (from the context I don't see it's messed up already)
> 

Will double check on v2...

- Nuno Sá
Jonathan Cameron June 11, 2022, 2:07 p.m. UTC | #3
On Fri, 10 Jun 2022 21:49:22 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Fri, 2022-06-10 at 16:45 +0200, Andy Shevchenko wrote:
> > On Fri, Jun 10, 2022 at 10:46 AM Nuno Sá <nuno.sa@analog.com> wrote:  
> > > 
> > > Do not trust the fact that iio.h includes of.h which in turn
> > > includes
> > > all the headers we are relying on.
> > > 
> > > The ultimate goal is to actually drop of.h from iio.h.  
> > 
> > ...
> >   
> > >  #include <linux/mod_devicetable.h>
> > >  #include <linux/mutex.h>
> > >  #include <linux/platform_device.h>
> > > +#include <linux/property.h>
> > > +#include <linux/of.h>  
> > 
> > Ordering (from the context I don't see it's messed up already)
> >   
> 
> Will double check on v2...

Fixed up whilst applying...

> 
> - Nuno Sá
diff mbox series

Patch

diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
index 2b3912c6ca6b..e731ba47add2 100644
--- a/drivers/iio/adc/ingenic-adc.c
+++ b/drivers/iio/adc/ingenic-adc.c
@@ -18,6 +18,8 @@ 
 #include <linux/mod_devicetable.h>
 #include <linux/mutex.h>
 #include <linux/platform_device.h>
+#include <linux/property.h>
+#include <linux/of.h>
 
 #define JZ_ADC_REG_ENABLE		0x00
 #define JZ_ADC_REG_CFG			0x04