| Message ID | 20220614194225.2226447-2-sravanhome@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/6] iio: adc: mp2629: fix wrong comparison of channel | expand |
On 14/06/2022 12:42, Saravanan Sekar wrote: > Add new compatible for mp2733 mfd driver. > > Signed-off-by: Saravanan Sekar <sravanhome@gmail.com> > --- > Documentation/devicetree/bindings/mfd/mps,mp2629.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > index f91acc42d652..fe13869e2c58 100644 > --- a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > +++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > @@ -19,6 +19,7 @@ description: | > properties: > compatible: > const: mps,mp2629 > + const: mps,mp2733 This does not look like proper syntax. Please run `make dt_binding_check` (see instructions in bindings directory) to validate it. Best regards, Krzysztof
On Tue, 14 Jun 2022 21:42:21 +0200, Saravanan Sekar wrote: > Add new compatible for mp2733 mfd driver. > > Signed-off-by: Saravanan Sekar <sravanhome@gmail.com> > --- > Documentation/devicetree/bindings/mfd/mps,mp2629.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/mfd/mps,mp2629.yaml:22:5: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/mfd/mps,mp2629.example.dts' Documentation/devicetree/bindings/mfd/mps,mp2629.yaml:22:5: found duplicate key "const" with value "mps,mp2733" (original value: "mps,mp2629") make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/mfd/mps,mp2629.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/mfd/mps,mp2629.yaml:22:5: found duplicate key "const" with value "mps,mp2733" (original value: "mps,mp2629") /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml: ignoring, error parsing file make: *** [Makefile:1404: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml index f91acc42d652..fe13869e2c58 100644 --- a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml +++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml @@ -19,6 +19,7 @@ description: | properties: compatible: const: mps,mp2629 + const: mps,mp2733 reg: maxItems: 1
Add new compatible for mp2733 mfd driver. Signed-off-by: Saravanan Sekar <sravanhome@gmail.com> --- Documentation/devicetree/bindings/mfd/mps,mp2629.yaml | 1 + 1 file changed, 1 insertion(+)