| Message ID | 20220615114746.2767-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] iio: proximity: sx_common: Don't use IIO device for properties | expand |
On Wed, Jun 15, 2022 at 4:47 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > IIO core correctly will take care of firmware node if it's not set in > the driver. Drop ACPI and OF specifics from the driver and allow IIO > core to handle this. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> > --- > v2: no changes > drivers/iio/proximity/sx_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iio/proximity/sx_common.c b/drivers/iio/proximity/sx_common.c > index 9f2e47385198..d70a6b4f0bf8 100644 > --- a/drivers/iio/proximity/sx_common.c > +++ b/drivers/iio/proximity/sx_common.c > @@ -5,7 +5,6 @@ > * Common part of most Semtech SAR sensor. > */ > > -#include <linux/acpi.h> > #include <linux/bitops.h> > #include <linux/byteorder/generic.h> > #include <linux/delay.h> > @@ -519,8 +518,6 @@ int sx_common_probe(struct i2c_client *client, > if (ret) > return dev_err_probe(dev, ret, "error reading WHOAMI\n"); > > - ACPI_COMPANION_SET(&indio_dev->dev, ACPI_COMPANION(dev)); > - indio_dev->dev.of_node = client->dev.of_node; > indio_dev->modes = INDIO_DIRECT_MODE; > > indio_dev->channels = data->chip_info->iio_channels; > -- > 2.35.1 >
On Wed, Jun 29, 2022 at 10:07:40AM -0700, Gwendal Grignou wrote: > On Wed, Jun 15, 2022 at 4:47 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > IIO core correctly will take care of firmware node if it's not set in > > the driver. Drop ACPI and OF specifics from the driver and allow IIO > > core to handle this. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Thanks! Jonathan, I guess we are ready with this series. What do you think?
On Sun, 3 Jul 2022 18:45:44 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Wed, Jun 29, 2022 at 10:07:40AM -0700, Gwendal Grignou wrote: > > On Wed, Jun 15, 2022 at 4:47 AM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > IIO core correctly will take care of firmware node if it's not set in > > > the driver. Drop ACPI and OF specifics from the driver and allow IIO > > > core to handle this. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Gwendal Grignou <gwendal@chromium.org> > > Thanks! > > Jonathan, I guess we are ready with this series. What do you think? > Gwendal's happy and seems straight forwards to me. Applied to the togreg branch of iio.git and pushed out as testing. Note, unlikely to make this cycle so I'll probably hold it in testing only until I can rebase on rc1. Thanks, Jonathan
diff --git a/drivers/iio/proximity/sx_common.c b/drivers/iio/proximity/sx_common.c index 9f2e47385198..d70a6b4f0bf8 100644 --- a/drivers/iio/proximity/sx_common.c +++ b/drivers/iio/proximity/sx_common.c @@ -5,7 +5,6 @@ * Common part of most Semtech SAR sensor. */ -#include <linux/acpi.h> #include <linux/bitops.h> #include <linux/byteorder/generic.h> #include <linux/delay.h> @@ -519,8 +518,6 @@ int sx_common_probe(struct i2c_client *client, if (ret) return dev_err_probe(dev, ret, "error reading WHOAMI\n"); - ACPI_COMPANION_SET(&indio_dev->dev, ACPI_COMPANION(dev)); - indio_dev->dev.of_node = client->dev.of_node; indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = data->chip_info->iio_channels;
IIO core correctly will take care of firmware node if it's not set in the driver. Drop ACPI and OF specifics from the driver and allow IIO core to handle this. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: no changes drivers/iio/proximity/sx_common.c | 3 --- 1 file changed, 3 deletions(-)