| Message ID | 20220616220023.9894-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/1] iio: dac: stm32-dac: Replace open coded str_enable_disable() | expand |
On Fri, 17 Jun 2022 01:00:23 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Replace open coded str_enable_disable() in error message in > stm32_dac_set_enable_state(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> +CC Fabrice. Looks good + harmless to me, so I'll pick it up now, but still time for any additional feedback as I'll only push it out for 0-day to poke at initially. Applied to the togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/dac/stm32-dac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c > index e842c15c674d..315d66648210 100644 > --- a/drivers/iio/dac/stm32-dac.c > +++ b/drivers/iio/dac/stm32-dac.c > @@ -14,6 +14,7 @@ > #include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > +#include <linux/string_helpers.h> > > #include "stm32-dac-core.h" > > @@ -79,8 +80,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, > ret = regmap_update_bits(dac->common->regmap, STM32_DAC_CR, msk, en); > mutex_unlock(&dac->lock); > if (ret < 0) { > - dev_err(&indio_dev->dev, "%s failed\n", en ? > - "Enable" : "Disable"); > + dev_err(&indio_dev->dev, "%s failed\n", str_enable_disable(en)); > goto err_put_pm; > } >
diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c index e842c15c674d..315d66648210 100644 --- a/drivers/iio/dac/stm32-dac.c +++ b/drivers/iio/dac/stm32-dac.c @@ -14,6 +14,7 @@ #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <linux/string_helpers.h> #include "stm32-dac-core.h" @@ -79,8 +80,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, ret = regmap_update_bits(dac->common->regmap, STM32_DAC_CR, msk, en); mutex_unlock(&dac->lock); if (ret < 0) { - dev_err(&indio_dev->dev, "%s failed\n", en ? - "Enable" : "Disable"); + dev_err(&indio_dev->dev, "%s failed\n", str_enable_disable(en)); goto err_put_pm; }
Replace open coded str_enable_disable() in error message in stm32_dac_set_enable_state(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/iio/dac/stm32-dac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)