diff mbox series

[net-next,v1,1/1] iio: adc: tsc2046: silent spi_device_id warning

Message ID 20220630075155.2718293-1-o.rempel@pengutronix.de (mailing list archive)
State Changes Requested
Headers show
Series [net-next,v1,1/1] iio: adc: tsc2046: silent spi_device_id warning | expand

Commit Message

Oleksij Rempel June 30, 2022, 7:51 a.m. UTC 
Add spi_device_id to silent following warning:
 SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/iio/adc/ti-tsc2046.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jonathan Cameron July 1, 2022, 4:49 p.m. UTC | #1 
On Thu, 30 Jun 2022 09:51:55 +0200
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> Add spi_device_id to silent following warning:
>  SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
If the device was probed via this path (old school board file
or similar) then the device_get_matchdata() call will fail.

So I think we need to add handling for this case.  Usually
along lines of
if (dev_fwnode)
	.. device_get_match_data()
else
	.. handle what is the spi_device_id structure


> ---
>  drivers/iio/adc/ti-tsc2046.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
> index 55b35570ad8b..27dc959aee37 100644
> --- a/drivers/iio/adc/ti-tsc2046.c
> +++ b/drivers/iio/adc/ti-tsc2046.c
> @@ -833,11 +833,18 @@ static const struct of_device_id ads7950_of_table[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ads7950_of_table);
>  
> +static const struct spi_device_id tsc2046_adc_spi_ids[] = {
> +	{ "tsc2046e-adc" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(spi, tsc2046_adc_spi_ids);
> +
>  static struct spi_driver tsc2046_adc_driver = {
>  	.driver = {
>  		.name = "tsc2046",
>  		.of_match_table = ads7950_of_table,
>  	},
> +	.id_table = tsc2046_adc_spi_ids,
>  	.probe = tsc2046_adc_probe,
>  };
>  module_spi_driver(tsc2046_adc_driver);
Andy Shevchenko July 1, 2022, 8:09 p.m. UTC | #2 
On Thu, Jun 30, 2022 at 9:59 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> Add spi_device_id to silent following warning:
>  SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc

...

> +static const struct spi_device_id tsc2046_adc_spi_ids[] = {
> +       { "tsc2046e-adc" },
> +       { },

No comma needed for terminator lines.

> +};
diff mbox series

Patch

diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
index 55b35570ad8b..27dc959aee37 100644
--- a/drivers/iio/adc/ti-tsc2046.c
+++ b/drivers/iio/adc/ti-tsc2046.c
@@ -833,11 +833,18 @@  static const struct of_device_id ads7950_of_table[] = {
 };
 MODULE_DEVICE_TABLE(of, ads7950_of_table);
 
+static const struct spi_device_id tsc2046_adc_spi_ids[] = {
+	{ "tsc2046e-adc" },
+	{ },
+};
+MODULE_DEVICE_TABLE(spi, tsc2046_adc_spi_ids);
+
 static struct spi_driver tsc2046_adc_driver = {
 	.driver = {
 		.name = "tsc2046",
 		.of_match_table = ads7950_of_table,
 	},
+	.id_table = tsc2046_adc_spi_ids,
 	.probe = tsc2046_adc_probe,
 };
 module_spi_driver(tsc2046_adc_driver);